Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339587 - Supply generalized event processing routines
Summary: Supply generalized event processing routines
Status: RESOLVED NOT_ECLIPSE
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 15:08 EST by Peder Andersen CLA
Modified: 2011-04-29 15:49 EDT (History)
1 user (show)

See Also:


Attachments
1 - generalize event processing thread routines (18.15 KB, patch)
2011-03-10 15:08 EST, Peder Andersen CLA
no flags Details | Diff
2 - decouple generic event queues from TCF's event dispatch (34.38 KB, patch)
2011-03-10 15:09 EST, Peder Andersen CLA
no flags Details | Diff
3 - Moved delayed event handling into a separate generic queue (21.40 KB, patch)
2011-03-10 15:10 EST, Peder Andersen CLA
no flags Details | Diff
4 - event queue callback argument is now the event node pointer (8.04 KB, patch)
2011-03-10 15:11 EST, Peder Andersen CLA
no flags Details | Diff
5 - make timed event queue a singleton (11.49 KB, patch)
2011-03-10 15:12 EST, Peder Andersen CLA
no flags Details | Diff
6 - Fixed timed event queue cancellation (5.65 KB, application/octet-stream)
2011-03-10 15:13 EST, Peder Andersen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peder Andersen CLA 2011-03-10 15:08:42 EST
Created attachment 190914 [details]
1 - generalize event processing thread routines

Best practices for writing command callback functions dictate that they
return reasonably promptly, and never block indefinitely.  To accomplish
this, many services provided by external packages will want to defer
portions of their command handler logic to their own event queues.
Rather than have every plugin implement their own event queue, it makes
sense to generalize and expose TCF's own event logic.

The attached patch series accomplishes this.  In particular, note that the first patch generalizes the existing event queue.  The second patch creates a new generic event queue object, and reverts TCF's event loop back to using its original logic.  Subsequent patches evolve the generic event queue, leaving TCF's original event logic untouched.

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 1 Peder Andersen CLA 2011-03-10 15:09:34 EST
Created attachment 190915 [details]
2 - decouple generic event queues from TCF's event dispatch

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 2 Peder Andersen CLA 2011-03-10 15:10:52 EST
Created attachment 190917 [details]
3 - Moved delayed event handling into a separate generic queue

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 3 Peder Andersen CLA 2011-03-10 15:11:42 EST
Created attachment 190918 [details]
4 - event queue callback argument is now the event node pointer

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 4 Peder Andersen CLA 2011-03-10 15:12:36 EST
Created attachment 190919 [details]
5 - make timed event queue a singleton

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 5 Peder Andersen CLA 2011-03-10 15:13:26 EST
Created attachment 190920 [details]
6 - Fixed timed event queue cancellation

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 6 Eugene Tarassov CLA 2011-04-29 15:49:21 EDT
After discussing this, agreement is do not include generic event queues support into TCF. Clients can implement such support them-self if needed.

Changing status to NOT_ECLIPSE.