Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339462 - [Crossfire] cannot set bp on CFScriptReference created from onScript event
Summary: [Crossfire] cannot set bp on CFScriptReference created from onScript event
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Grant Gayed CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 00:05 EST by Grant Gayed CLA
Modified: 2011-03-10 11:18 EST (History)
1 user (show)

See Also:

Attachments
patch (15.14 KB, patch)
2011-03-10 00:30 EST, Grant Gayed CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2011-03-10 00:05:12 EST 
- connect to a Crossfire server
- show JS scripts in the debugger
- navigate to a page, open one of its scripts, set a breakpoint on it, works fine
- now refresh the browser, which rebuilds the tree of scripts based on received onScript events
- the previously-set breakpoint can be cleared, but attempting to set a new breakpoint will not send a setbreakpoint request to the server

The problem is that when CFScriptReference is initialized from an onScript event, rather than from CFVirtualMachine.allScripts(), the json Map it's given does not contain very much because onScript events are not spec'd to return line counts, etc.  As a result the CFScriptReference's linelocs are not properly initialized.
Comment 1 Grant Gayed CLA 2011-03-10 00:30:19 EST 
Created attachment 190819 [details]
patch
Comment 2 Michael Rennie CLA 2011-03-10 09:50:05 EST 
Changes in the crossfire protocol have all but mitigated this problem, although I can see the value in the patch: in case you are running on a version of crossfire that does not have the new packet shape OR crossfire failed to get script meta-data, we should try sending a 'script' request for the infos.

The related crossfire bug is:

http://code.google.com/p/fbug/issues/detail?id=3476
Comment 3 Grant Gayed CLA 2011-03-10 11:18:04 EST 
I've changed the IE server to send the more detailed onScript events, so this now works with the latest JSDT.