Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339414 - HeapWalking manager should support other debug targets that can provide an IJavaDebugTarget adapter
Summary: HeapWalking manager should support other debug targets that can provide an IJ...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 342073
  Show dependency tree
 
Reported: 2011-03-09 14:07 EST by Michael Rennie CLA
Modified: 2011-05-26 14:35 EDT (History)
2 users (show)

See Also:

Attachments
proposed fix (1.02 KB, patch)
2011-03-09 14:07 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2011-03-09 14:07:52 EST 
Created attachment 190782 [details]
proposed fix

Version: 3.7.0
Build id: I20110307-2110 (and all versions since heap-walking was added)

In its current state, the method HeapWalkingManager#supportsHeapWalking only considers if the supplied object is an instance of IJavaDebugTarget. If the given object is not an instance of IJavaDebugTarget we should ask it for an IJavaDebugTarget adapter, allowing other debug targets to take part in heap-walking.
Comment 1 Natasha D'Silva CLA 2011-03-10 18:56:45 EST 
Hi Mike,
Im running into some strange errors in my testing - I'm not sure if they're related tp the patch so I'll do some more testing and update next weel.
Comment 2 Natasha D'Silva CLA 2011-03-14 14:56:41 EDT 
(In reply to comment #1)
> Hi Mike,
> Im running into some strange errors in my testing - I'm not sure if they're
> related tp the patch so I'll do some more testing and update next weel.
related *to the patch,
update next *week:

I think the patch looks good so you can go ahead and check this in,
Thanks.
Comment 3 Michael Rennie CLA 2011-03-22 13:44:38 EDT 
applied patch to HEAD