Community
Participate
Working Groups
Steps: 1) Create couple top-level folders 2) Select them all and use 'More actions > Delete' 3) Projects are deleted but the menu is still visible
Created attachment 190758 [details] Illustration
The menu disappears after a refresh.
several things at play here. Long term, the selection needs to be retained when refreshing the UI after an operation, and if the operation changes the selection, then the selection service needs to fire a notification. Short term, for the delete case, there are no selections to be saved, so setting selections to empty would fire the listener and remove the menu. M6 candidate pending triage.
The situations I noticed this bug in: - after deleting resources the selection is cleared but the action still have the previous selection, so you can schedule deletion of same resources twice - adding a new file/folder to a folder where the selection is made clears the selection but menu stays and has the old selection - selecting a resource in a folder then collapsing and expanding again the folder I took a simple shoot to fix it and I added this code: this.explorer.registry.getService("ISelectionService").then(dojo.hitch(this, function(service) { service._setSelection(this.getSelected()); })); to function eclipse.FileRenderer.rowsChanged() in explorer-table.js. It works for all the cases I named above. But I suppose you've been thinking about it already so I'll leave it to you.
(In reply to comment #4) > The situations I noticed this bug in: > - after deleting resources the selection is cleared but the action still have > the previous selection, so you can schedule deletion of same resources twice > - adding a new file/folder to a folder where the selection is made clears the > selection but menu stays and has the old selection > - selecting a resource in a folder then collapsing and expanding again the > folder > > I took a simple shoot to fix it and I added this code: > > this.explorer.registry.getService("ISelectionService").then(dojo.hitch(this, > function(service) { > service._setSelection(this.getSelected()); > })); > > to function eclipse.FileRenderer.rowsChanged() in explorer-table.js. It works > for all the cases I named above. That's the right fix. > But I suppose you've been thinking about it already so I'll leave it to you. Not really, I'm just now getting to this bug. Thanks for the investigation.
Fixed. We still need a better long term fix, see bug 339450.
