Community
Participate
Working Groups
A link to Orion wiki page[1] and an easy way of reporting a bug[2] would be useful not only for developers but for others trying out Orion. [1] http://wiki.eclipse.org/Orion [2] https://bugs.eclipse.org/bugs/enter_bug.cgi?product=e4&component=Orion&version=0.2
Good point. For the instance running on orion.eclipse.org we need a hook for their footer anyway. Instead of the main wiki page, how about we link to the FAQ page? Finding other wiki pages from there is easy, and a FAQ is probably what people would be willing to check if they encounter problems or have questions.
(In reply to comment #1) > Instead of the main wiki page, how about we link to the FAQ page? Fine with me.
I can take this. The solution will be similar to the top banner. We'll have an empty div in every page for the bottom area and an HTML fragment declared in some javascript that populates it. I call this "brute force client-side templating." It would be pretty to have the fragment in some file, but we don't want to have to turn around and GET it. Nathan can then replace the fragment for the foundation installation.
I thought about programmatically forcing a bottom pane in the border container, but I don't trust that our BorderContainer id's are all the same, etc. So I'm going to have to touch each page and assign a well down bottom div id. Pages affected: navigate-table.html coding.html searchResults.html view-registry.html git-status.html compare.html unittest.html sites.html edit-site.html user profile Any others?
The list looks complete to me.
I've added footers to all of the pages. Released all pages EXCEPT: coding.html compare.html It seems that the dynamic population of the footer is happening too late, so the editor has already placed its horizontal scrollbar, which then gets covered up by the bottom banner. I need to figure out how to handle that. It may mean hard-coding a footer height in those two pages, because as I recall, we need the editor to be created before we call the code that generates banner (and footer).
Fixed. I made the footer fixed height to avoid the editor/scrollbar issues. Here are instructions for changing the footer. (ie, for the foundation server, or if we decide we want something different). The HTML fragment is defined as bottomHTMLFragment in org.eclipse.orion.client.core/static/js/globalCommands.js The div containing this fragment is assigned a class "footer" and this class is defined in ide.css
(In reply to comment #7) > Here are instructions for changing the footer. (ie, for the foundation server, > or if we decide we want something different). > > > The HTML fragment is defined as bottomHTMLFragment in > org.eclipse.orion.client.core/static/js/globalCommands.js > > The div containing this fragment is assigned a class "footer" and this class is > defined in ide.css I don't know if this is the right place, but just reporting that the experience of updating the footer on orion.eclipse.org for M6 was terrible. Because "globalCommands.js" gets minified into several files in our build, to update the footer I had to make the same edit in several minified js files on the orion server. This felt like a painful and error-prone mechanism for customizing the footer...
(In reply to comment #8) I entered a new bug 340019 to figure out how the header/footer include mechanism plays with minification.
