Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339302 - [client] [ie] banner layout has extra pixels in IE8
Summary: [client] [ie] banner layout has extra pixels in IE8
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 19:24 EST by Susan McCourt CLA
Modified: 2011-09-01 11:42 EDT (History)
0 users

See Also:


Attachments
snapshot of problem (21.19 KB, image/png)
2011-03-08 19:24 EST, Susan McCourt CLA
no flags Details
screenshot (13.36 KB, image/png)
2011-03-08 21:12 EST, Susan McCourt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-03-08 19:24:15 EST
Created attachment 190716 [details]
snapshot of problem

The "new look" with the orion sphere overlaying the dark toolbar is achieved through some table (!?!) layout.  In trying a bunch of different layout choices, this was the only reliable way to stretch the toolbar over the width of the page, and ensure bottom/right alignment.  (you can't mix CSS float with absolute positioning).

This works well on FF and Chrome, but there are extra pixels in IE that cause a vertical scrollbar to appear in the banner.

It appears as if there are about 4 extra pixels on the bottom of each row in the table that do not appear in the other browsers. 

The screenshot shows the banner when scrolled to the top and also when scrolled to the bottom.  (The green is a debugging color I'm using to see the dom sizes).

Searching around on this issue reveals that the IE difference is "usually" because there is an embedded blank text node somewhere in the table and IE generates space around the content for this.  It could also be a different css default, but I've tried all kinds of CSS changes to no avail.
Comment 1 Susan McCourt CLA 2011-03-08 19:44:43 EST
the pixels are appearing in chrome now also.  They were not there last night when I first noticed this.  I think that as I've increased content in the lower bar this has been introduced.
Comment 2 Susan McCourt CLA 2011-03-08 20:58:19 EST
I removed all content from the table columns and the problem persists, so it's something with the table/tr/td styling (padding, borders, etc.) rather than something introduced by the content in the tds.
Comment 3 Susan McCourt CLA 2011-03-08 21:12:19 EST
Created attachment 190720 [details]
screenshot

fixed the problem on chrome, which was introduced when I added a generous padding-top to the top left and right toolbars.  This forced the tablerow to be too large.

The IE problem persists.  The snapshot shows that there are three extra pixels introduced at the bottom of the table.  This causes the scrolling.
Comment 4 Susan McCourt CLA 2011-03-08 21:26:51 EST
Fixed.
For the life of me I don't know where those extra pixels are coming from, but I verified they are appended to the bottom of the table, rather than caused by changing the spread of the two toolbars.

So...the workaround is to change the CSS in the toolbar to
overflow: hidden

so that the mystery pixels are clipped.