Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339298 - ElementCollection Map attribute overrides are being incorrectly validated
Summary: ElementCollection Map attribute overrides are being incorrectly validated
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Nan Li CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 18:02 EST by Karen Butzke CLA
Modified: 2011-05-03 11:55 EDT (History)
1 user (show)

See Also:
neil.hauge: review+


Attachments
jpa eclipselink project (13.03 KB, application/x-sdlc)
2011-03-08 18:02 EST, Karen Butzke CLA
no flags Details
Proposed Patch (3.42 KB, patch)
2011-04-18 11:06 EDT, Nan Li CLA
neil.hauge: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2011-03-08 18:02:22 EST
Created attachment 190712 [details]
jpa eclipselink project

In the PropertyRecord class in the attached project the ElementCollection key and value attribute overrides have incorrect validation errors. There should be no validation errors. It is incorrectly validating the key attribute overrides against the value class and the value attribute overrides against the key class.

This is a regression in a 3.0 milestone
Comment 1 Karen Butzke CLA 2011-03-10 08:06:51 EST
You can see the problem if you look in the Value section of the JPA Details view. You'll notice that the key.street attribute override is part of the list of value attribute overrides. Change something in the java source code, maybe a column name, when another sync occurs the key.street attribute override disapears along with the incorrect validation errors. Looks like an issue where the attribute overrides need to be sync'd in the update
Comment 2 Nan Li CLA 2011-04-18 11:06:58 EDT
Created attachment 193493 [details]
Proposed Patch
Comment 3 Neil Hauge CLA 2011-04-21 17:06:46 EDT
Patch committed to head.
Comment 4 Neil Hauge CLA 2011-04-21 17:06:55 EDT
.