Community
Participate
Working Groups
Created attachment 190702 [details] deltas.xml - I had a build from last week (4.1.0.I20110304-1022) - I updated to last night's build (4.1.0.I20110307-2200) - the toolbars for my stacked views were: - missing icons - showing the wrong drop-down menus (from others in the stack) - showing multiple drop-down menus - missing the min/max buttons Paul and I quickly looked at it and if you grabbed the side of the view and made it smaller, then the icons eventually appeared. But adjusting the view back to regular size made them disappear again. I've attached the deltas.xml file at Paul's request. I will also attach a screenshot.
Created attachment 190703 [details] screen shot
I just saw a manifestation of this problem also but don't remember if it was on a new or existing workspace.
Created attachment 190879 [details] ToolBar rendering patch v1 We had code that would check for MRenderedToolBars and ask the renderer to remove its gui instead of disposing the [top right] control [of a tab folder] directly. The disposeWidget(Object) implementation disposed the ToolBar but did not dispose the Composite. This seemed to cause a spacing problem where the tab folder would constantly get more controls created, essentially preventing anything from showing up there. Since the above check only applied to MRenderedToolBars, new workspaces that used MToolBars were not technically affected by this since the whole thing got disposed and recreated while swapping between views in a stack. However, this only _looks_ correct visually. By eagerly disposing these controls, it meant that the contribution items would be disposed even when they shouldn't be. This means the return of bug 304863, try it in an outer, it has now become reproducible again. --------- The proposed fix is to only make the control invisible in the disposeWidget(Object) method but to not do anything else. At the same time, when a model element that already has a control is created, we explicitly force the control to be visible so that it will come back. The change to unset a tab folder's top right control comes from the way 'Reset Perspective' works. The reset perspective is reconstructed and inserted into the window then the original one is disposed of. Therein lies the problem. When the perspective is reconstructed the controls are parented properly and everything, but once the original one goes through the unrendering phase the tab folder goes through the motion of unrendering its top right control's model element which causes said control to become invisible (as noted by the paragraph above). So the fix here is to ensure that if we were originally the top right control of our parent tab folder that we unset that tab folder's top right control so that this link is no longer there. This means that when the renderer gets to unrendering our old parent's tab folder that it won't have any record of its tool bar and won't try to unrender it.
There seems to be a layout problem with a view's tool bar. If you run an application the 'Console' view gets more items but they are not automatically visible. Resizing will show all of them. This doesn't appear to be related to the patch as it happens in my outer also.
(In reply to comment #4) > There seems to be a layout problem with a view's tool bar. If you run an > application the 'Console' view gets more items but they are not automatically > visible. Resizing will show all of them. This doesn't appear to be related to > the patch as it happens in my outer also. This is a problem that also occurs in 3.x ... we will need to address it, but it's not related to these changes. PW
The patch looks alright to me. The only thing I'd change is that the return statement in the PRE should be switched back to 'element.getWidget()' since this *must* be true.
(In reply to comment #6) > The patch looks alright to me. The only thing I'd change is that the return > statement in the PRE should be switched back to 'element.getWidget()' since > this *must* be true. Change released to HEAD.
Verified with I20110310-2200 on Windows XP that DJ's deltas are now okay and that the 'Outline' and 'Variables' view's tool bars don't grow to strange sizes.
*** Bug 339249 has been marked as a duplicate of this bug. ***
