Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339267 - TrayDialog closes the tray if the help button is pressed with a cheat sheet open
Summary: TrayDialog closes the tray if the help button is pressed with a cheat sheet open
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 13:25 EST by Chris Goldthorpe CLA
Modified: 2011-04-27 08:41 EDT (History)
3 users (show)

See Also:


Attachments
Patch 0.1 (1.80 KB, patch)
2011-03-10 16:25 EST, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2011-03-08 13:25:21 EST
I20110307-0800

Help/Cheat Sheets
Open Java Development/Create a Hello World Application. A cheat sheet will open.

Follow through the steps of the cheat sheet until you get to "Create a Java Project" and press the button to create the project. A New Java Project dialog will open.

Press the '?' button.

Expected result - help is shown in the tray
Actual result - the tray is closed

This is a regression caused by the fix for Bug 127852. We need to improve the logic that determines when to close the tray.
Comment 1 Markus Keller CLA 2011-03-10 16:25:02 EST
Created attachment 190929 [details]
Patch 0.1

The problem is that the TrayDialog creates a help button, but it doesn't really know if the tray contains help or something else.

Here's a potential solution that would work without new APIs. It fixes comment 0, but it doesn't set the help button to 'pressed' state when the user opened help via F1 (and not via the help button).


For the perfect solution, we'd have to add something like DialogTray#isHelpTray(), which would be false for cheat sheets but true for actual help.
Comment 2 Chris Goldthorpe CLA 2011-03-14 12:40:39 EDT
I think that Patch 0.1 is a perfectly good solution. I don't think that users who open the tray using F1 will expect that pressing the (?) will close the tray.
Comment 3 Markus Keller CLA 2011-03-14 13:34:08 EDT
(In reply to comment #2)
> I think that Patch 0.1 is a perfectly good solution.

Thanks, released to HEAD.
Comment 4 Markus Keller CLA 2011-04-27 08:41:13 EDT
Verified in I20110426-2000.