Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339242 - [server] Compile error due to dependency on JGit head
Summary: [server] Compile error due to dependency on JGit head
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 11:15 EST by John Arthorne CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-03-08 11:15:06 EST
JGit added a new method CommitCommand.setAppend(). This change hasn't appeared in a stable JGit build yet, but we started referencing it in our GitCommitHandlerV1. This causes a compile error in our build.
Comment 1 John Arthorne CLA 2011-03-08 11:21:54 EST
I have reverted the change on our side for now so we can do an integration build. Once our build is consuming a stable build of JGit that contains the change, we can add it back.
Comment 2 Tomasz Zarna CLA 2011-03-08 11:35:42 EST
I will handle this: will check if the new method is shipped with a JGit build in M7. Sorry for the trouble.
Comment 3 Tomasz Zarna CLA 2011-03-08 11:56:20 EST
I've marked org.eclipse.orion.server.tests.servlets.git.GitCommitTest.testCommitAmend() to be ignored, otherwise it would fail.
Comment 4 Tomasz Zarna CLA 2011-03-14 05:28:13 EDT
The latest n-build from JGit is 0.12.0.201103040915. The fix (bug 339088) is definitely not there yet. Will check again next week.
Comment 5 Tomasz Zarna CLA 2011-04-05 09:46:04 EDT
The fix is in JGit 0.12.0.201104032215 and later. I'm re-enabling the amend switch in server API, see http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=b1a55353e7e3f47458a2b248c2708d61dcc29b5b.