339220 – Login and password don't get used or stored.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339220 - Login and password don't get used or stored.

Summary: Login and password don't get used or stored.

Status:	RESOLVED FIXED

Alias:	None

Product:	EGit
Classification:	Technology
Component:	Core (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 major with 2 votes (vote)
Target Milestone:	3.3
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-03-08 08:25 EST by Stephan Kleine
Modified:	2014-04-01 11:53 EDT (History)
CC List:	11 users (show)

See Also:

Attachments
Jgit patch (2.79 KB, patch) 2011-06-24 22:55 EDT, Marc-André Laperle	no flags	Details \| Diff
Egit patch (624 bytes, patch) 2011-06-24 22:56 EDT, Marc-André Laperle	no flags	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stephan Kleine

2011-03-08 08:25:20 EST

Build Identifier: 20110301-1815

I'm using gitweb with the "smart" http protocol behind an Apache 2 configured with basic http authentication. The problem is that while there are "User" and "Password" fields when configuring remote push and fetch URLs the entered values never get stored or used which makes it impossible to use any remote repository that requires authentication. This happens regardless if that "Use secure storage" checkbox is ticked or not.

EGit version is 0.11.3 from your update site.

Reproducible: Always

Steps to Reproduce:
Try to fetch something from a remote repo via the smart http protocol requiring basic authentication.

Comment 1 Lars Kneschke

2011-04-24 02:55:04 EDT

See also bug #342592 and #338048.

The only way to get authentication working is to enter the username and password in the git repository url. Which is very unsecure, as the git repository get's added to commit messages sometimes.

Comment 2 Marc-André Laperle

2011-06-24 22:55:51 EDT

Created attachment 198594 [details]
Jgit patch

Comment 3 Marc-André Laperle

2011-06-24 22:56:54 EDT

Created attachment 198595 [details]
Egit patch

Comment 4 Marc-André Laperle

2011-06-24 23:01:22 EDT

The patches are probably not great since I know almost nothing about git/egit/jgit but I hope it will put someone in the right direction.

Comment 5 Marc-André Laperle

2011-06-27 11:43:56 EDT

Comment on attachment 198595 [details]
Egit patch

Eh, now it never ask for the password for secure storage.

Comment 6 Mykola Nikishov

2012-03-03 11:12:34 EST

[Batch change] Remove passed Target Milestones

If anyone on CC list is going to fix/implement this, feel free to assign a new, post-1.3/2.0, target milestone.

Comment 7 Matthias Sohn

2014-03-17 06:10:05 EDT

proposed patch https://git.eclipse.org/r/#/c/23443/

Comment 8 Matthias Sohn

2014-03-24 17:16:50 EDT

jgit:
https://git.eclipse.org/r/#/c/23441/
merged as 8598fe3d2bdc6e4a7e136a8579fad2545f34f546

egit:
https://git.eclipse.org/r/#/c/23643/
merged as bba4e7ff4321b0748d4687e0d40bbf23de5a81d3
https://git.eclipse.org/r/#/c/23443/
merged as b5a2d497ae44fa7ba99a93bb31fc2f0c7c8b7304