339202 – [client] Clicking on the Orion icon when in view-registry.html doesn't work

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339202 - [client] Clicking on the Orion icon when in view-registry.html doesn't work

Summary: [client] Clicking on the Orion icon when in view-registry.html doesn't work

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Client (show other bugs)
Version:	0.2
Hardware:	PC Windows XP

Importance:	P3 trivial (vote)
Target Milestone:	0.2
Assignee:	Susan McCourt
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-03-08 07:11 EST by Tomasz Zarna
Modified:	2011-09-01 11:42 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomasz Zarna

2011-03-08 07:11:56 EST

After clearing my plug-ins registry[1] I wanted to navigate back to Orion home page, unfortunately clicking on the Orion icon in the top left corner didn't work.

[1] http://localhost:8080/view-registry.html

Comment 1 Mark Macdonald

2011-03-08 10:21:07 EST

View-registry needs to generate the banner using the utility function from globalCommands.js

Comment 2 Susan McCourt

2011-03-08 10:35:09 EST

I'll take this, I think there are several pages that need the common banner still.

Comment 3 Susan McCourt

2011-03-08 13:23:38 EST

looks like unit test and plug-in registry need the common banner.  I'll take care of this.  If anyone knows of any others, please append here.

Comment 4 Susan McCourt

2011-03-08 15:11:54 EST

fixed unittest and view-registry.
I had a little trouble getting the dojo text box to align properly in the bottom bar, so I switched it to a regular input.  This means we won't validate the URL on every keystroke and keep the install button enabled/disabled.  I think we can live with it.
Also did some minor cleanup in sites.html (color and margin) and fixed a bug whereby the global commands weren't rendering if a handler was not passed into generateBanner.