Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339170 - Change-Id is removed from amended commit
Summary: Change-Id is removed from amended commit
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.12   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 02:53 EST by Stefan Lay CLA
Modified: 2011-05-30 08:19 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Lay CLA 2011-03-08 02:53:53 EST 
When I unselect the new preference "Insert Change-Id..." and I amend a commit which had a Change-Id, the Change-Id is deleted.
Comment 1 Stefan Lay CLA 2011-03-09 09:25:19 EST 
fix proposed at http://egit.eclipse.org/r/2676
Comment 2 Philipp Thun CLA 2011-03-16 11:30:36 EDT 
The same thing happened for me :-(

I have tested your fix and the Change-Id does not disappear now - that's fine. But the checkboxes "Add Signed-off-by" and "Compute Change-Id ..." are unchecked. If I check them, strange things happen, i.e. another "Signed-off-by" line is appended. I would propose to enable these checkboxes in case the information is already there.