Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339148 - destination files files not created from zip
Summary: destination files files not created from zip
Status: RESOLVED FIXED
Alias: None
Product: WTP Releng
Classification: WebTools
Component: releng (show other bugs)
Version: 3.10   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.10.0   Edit
Assignee: David Williams CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 16:52 EST by David Williams CLA
Modified: 2018-06-29 15:30 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-03-07 16:52:43 EST
A recent I-build recently failed with a msg such as below. I'm not sure, but one hypothesis is that the required jar was just deleted out from under the build job by the routine "clean up" job. That is, it was being too agressive (or, more precisely, using the wrong thing to "measure". It is supposed to only remove things if "older than 14 days" ... but, might have been using one of the higher directories time stamps? 


= = =  = = 

167093 [build-wtp-wst-sdk] /shared/webtools/projectBuilders/wtp-R3.3.0-I/webtools.releng/releng.wtpbuilder/scripts/build/buildutilitiesp2.xml:89: java.io.FileNotFoundExcepti       on: /shared/webtools/tmp/tempupdatepackproperties/temp-I-3.3.0-20110307204516-wst-sdk/features/org.eclipse.wst.common.fproj.sdk_3.3.0.v201102150115-787IFBVApOGQPIOLGH       YNY785BBB.jar (No such file or directory)
Comment 1 David Williams CLA 2011-03-07 21:17:10 EST
It appears they are not "deleted too soon" (as I originally thought) but never created (unzipped) there to begin with. 

Probable reason is related to updating our "tools" to include new ant-to-php task and, I suspect, I introduced some changed in "update pack properties" task that were in head, but never used/released. In the worst case, I could revert tools level ... but will try a few runs to push through and fix issue.
Comment 2 David Williams CLA 2011-03-07 23:44:38 EST
As far as I can tell ... when having previous problems ... long ago ... deleting files from build.eclipse.org file system (which uses NFS), I added some code to not create empty directories from zip file entries. (It didn't seem to help the could-no-delete problems on build machine ... but...)  I thought I'd released and had been using that, but apparently I was confused ... long ago ... and that code has not been in fact been running. So, when I updated for the ant-to-php task, the version of updatePackProperties task got updated also to not create empty directories. The problem, I think, is that directories such as "features" and "plugins" come across first as empty directories, and if they are not created, other file creation operations fail silently .. as far as I can tell. 

In any case, it's working now, happily creating empty directories, and still not able to delete them (immediately). But, we can sign again. 

[FWIW, this wasn't noticed on test builds of the ant-to-php task, since we don't sign on test build machines, so that updated code for updatePackProperties was never ran on test machine.]