Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339137 - New committers are not always created in the Foundation Database
Summary: New committers are not always created in the Foundation Database
Status: CLOSED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Project Management & Portal (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Portal Bugzilla Dummy Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 14:25 EST by Wayne Beaton CLA
Modified: 2011-03-09 21:41 EST (History)
2 users (show)

See Also:


Attachments
mylyn/context/zip (18.21 KB, application/octet-stream)
2011-03-07 14:46 EST, Wayne Beaton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2011-03-07 14:25:49 EST
We have been finding some committer records missing from the Foundation database. In the two most recent cases, the person being elected to the project has an existing role in the project. Specifically, in these two most recent cases, the individual being elected as a committer was already the project lead of the corresponding project. That this bug has surfaced now may be the result of a slight change in the way we execute project provisioning: i.e. in some cases, an over-vigilant EMO has designated the PL before the project provisioning request comes in. In this case, the individual already has a relationship with the project and the committer record is not created.

I can see exactly where this is probably happening in the portal code; specifically in committer_vote_summary.class.php#set_sent_to_webmaster()

The check code that determines whether or not a relationship pre-exists should be updated to determine if a 'CM' relationship pre-exists. Even better would be to just rely on the database's ability to manage its own primary keys and do an "insert ignore"
Comment 1 Wayne Beaton CLA 2011-03-07 14:46:21 EST
Fix committed.

Webmaster, can you roll out a portal update from HEAD, please?
Comment 2 Wayne Beaton CLA 2011-03-07 14:46:22 EST
Created attachment 190593 [details]
mylyn/context/zip
Comment 3 Eclipse Webmaster CLA 2011-03-09 16:05:27 EST
Done.

-M.
Comment 4 Wayne Beaton CLA 2011-03-09 21:41:02 EST
Thanks Matt. Marking as FIXED.