Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339129 - Perspective reset actions are not consistent.
Summary: Perspective reset actions are not consistent.
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Oleg Besedin CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 14:00 EST by Oleg Besedin CLA
Modified: 2011-03-18 03:38 EDT (History)
3 users (show)

See Also:

Attachments
Patch (6.64 KB, patch)
2011-03-07 14:03 EST, Oleg Besedin CLA 		no flags Details | Diff
Screenshot (9.71 KB, image/png)
2011-03-07 14:07 EST, Oleg Besedin CLA 		no flags Details
Patch 2 (7.81 KB, patch)
2011-03-07 16:03 EST, Oleg Besedin CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2011-03-07 14:00:32 EST 
There are two perspective reset actions: one from the toolbar area and one in the preference page.  The behaviour of these actions is different.

If there is customization to the perspective, the "Reset perspective" command available from the perspective switcher resets perspective to the customized version, not pre-defined layout.

The "Reset" button on Perspectives preferences page reset perspective to the pre-defined layout discarding customization.

Issues:
1. The different behavior associated with those 2 "reset" button.
2. The "true" reset button is very hard to discover.
Comment 1 Oleg Besedin CLA 2011-03-07 14:03:12 EST 
Created attachment 190587 [details]
Patch
Comment 2 Oleg Besedin CLA 2011-03-07 14:07:45 EST 
Created attachment 190588 [details]
Screenshot

The message box that will be shown on the perspective's switcher "Reset perspective" when we deal with a pre-defined customized perspective.

The patch changes note on the Perspective's preferences page to read:

   Reset removes customization of a predefined perspective.
   It takes effect the next time the perspective is opened
Comment 3 Boris Bokowski CLA 2011-03-07 15:20:39 EST 
Maybe use the word "Revert" instead of "Reset" in the preference page?
Comment 4 Oleg Besedin CLA 2011-03-07 16:03:26 EST 
Created attachment 190600 [details]
Patch 2

(In reply to comment #3)
> Maybe use the word "Revert" instead of "Reset" in the preference page?

Good idea. I'll also update the screenshot for the preference page in 

   org.eclipse.platform.doc.user\images\Image223_pref_persp.png
Comment 5 Oleg Besedin CLA 2011-03-14 10:10:52 EDT 
Patch applied to CVS Head.
Comment 6 Dani Megert CLA 2011-03-16 07:19:01 EDT 
Looks good!

The note on the preference page should use 'Revert' instead of "Revert" and I would tweak it a bit. How about:

RevertPerspective_note='Revert' removes the customization from the selected perspective.\nThis only applies to newly opened perspectives.
Comment 7 Oleg Besedin CLA 2011-03-17 12:05:45 EDT 
(In reply to comment #6)
> Looks good!
> 
> The note on the preference page should use 'Revert' instead of "Revert" and I
> would tweak it a bit. How about:
> 
> RevertPerspective_note='Revert' removes the customization from the selected
> perspective.\nThis only applies to newly opened perspectives.

Done, thank you for the text. Also updated the screenshot.
Comment 8 Dani Megert CLA 2011-03-18 03:38:43 EDT 
Verified in N20110317-2000.