Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339015 - Preference "Show source roots at the top of project" should also apply for Make Target View
Summary: Preference "Show source roots at the top of project" should also apply for Ma...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Andrew Gvozdev CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-05 14:33 EST by Andrew Gvozdev CLA
Modified: 2011-05-13 11:07 EDT (History)
1 user (show)

See Also:

Attachments
patch (30.73 KB, patch)
2011-03-07 17:24 EST, Andrew Gvozdev CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gvozdev CLA 2011-03-05 14:33:17 EST 
Source folders are shown directly on project root in PE. That allows to avoid repetitive expanding for source folders deep down in the project directory tree. It should also be that way for Make Target View.
There is also preference C++/Appearance/"Show source roots at the top of project" which controls that representation (introduced in bug 181020), it should also work for MTV.
Comment 2 Andrew Gvozdev CLA 2011-03-07 17:24:51 EST 
Created attachment 190605 [details]
patch

patch if anybody cares
Comment 3 Andrew Gvozdev CLA 2011-03-08 14:30:36 EST 
Committed patch to the HEAD (8.0).
Comment 4 CDT Genie CLA 2011-03-08 15:23:28 EST 
*** cdt cvs genie on behalf of agvozdev ***
bug 339015: Preference "Show source roots at the top of project" should also apply for Make Target View

[*] AbstractTargetAction.java 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/actions/AbstractTargetAction.java?root=Tools_Project&r1=1.12&r2=1.13

[*] MakeContentProvider.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/MakeContentProvider.java?root=Tools_Project&r1=1.17&r2=1.18
[*] MakeLabelProvider.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/MakeLabelProvider.java?root=Tools_Project&r1=1.13&r2=1.14
[+] TargetSourceContainer.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/TargetSourceContainer.java?root=Tools_Project&revision=1.1&view=markup

[*] MakeView.java 1.26 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/views/MakeView.java?root=Tools_Project&r1=1.25&r2=1.26
[*] FilterEmtpyFoldersAction.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/views/FilterEmtpyFoldersAction.java?root=Tools_Project&r1=1.1&r2=1.2
[*] PasteTargetAction.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/views/PasteTargetAction.java?root=Tools_Project&r1=1.3&r2=1.4
[*] AddTargetAction.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/views/AddTargetAction.java?root=Tools_Project&r1=1.14&r2=1.15

[*] AbstractContainerAreaDropAdapter.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/internal/ui/dnd/AbstractContainerAreaDropAdapter.java?root=Tools_Project&r1=1.4&r2=1.5
Comment 6 Andrew Gvozdev CLA 2011-03-11 14:39:30 EST 
Committed on HEAD also the change to update the views after changing preferences