Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 339007 - externalize strings for 3.5
Summary: externalize strings for 3.5
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.5   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-05 07:52 EST by Frank Becker CLA
Modified: 2011-03-07 16:44 EST (History)
4 users (show)

See Also:

Attachments
patch V1 (44.30 KB, patch)
2011-03-05 14:32 EST, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (18.43 KB, application/octet-stream)
2011-03-05 14:32 EST, Frank Becker CLA 		no flags Details
patch V2 (959 bytes, patch)
2011-03-06 05:01 EST, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (18.67 KB, application/octet-stream)
2011-03-06 05:01 EST, Frank Becker CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Becker CLA 2011-03-05 07:52:54 EST 
By example this is in 
Resource: org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/BugzillaUiPlugin.java
Location: line 104

but  it is not only in the Bugzilla component

Steffen, should we fix this after 3.5 is shipped?
Comment 1 Frank Becker CLA 2011-03-05 14:32:51 EST 
Created attachment 190474 [details]
patch V1

Here the patch for 3.6
Comment 2 Frank Becker CLA 2011-03-05 14:32:54 EST 
Created attachment 190475 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2011-03-05 22:21:34 EST 
Thanks for raising that. We should fix it for 3.5. Please feel free to commit the patch.
Comment 4 Frank Becker CLA 2011-03-06 05:01:07 EST 
Created attachment 190486 [details]
patch V2

I found an not needed @SuppressWarnings("unchecked") but can not commit to org.eclipse.mylyn.contexts.

Can someone commit this.
Comment 5 Frank Becker CLA 2011-03-06 05:01:09 EST 
Created attachment 190487 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2011-03-06 18:59:05 EST 
Thanks Frank. The warning in context was left intentionally as we have pending patch for that.