Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338974 - package feature has a different "license" (SUA)
Summary: package feature has a different "license" (SUA)
Status: CLOSED FIXED
Alias: None
Product: EPP
Classification: Technology
Component: package content (show other bugs)
Version: 1.3.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4.0M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 15:39 EST by David Williams CLA
Modified: 2014-05-08 13:34 EDT (History)
1 user (show)

See Also:


Attachments
patch for all product definitions (119.06 KB, patch)
2013-04-11 16:41 EDT, David Williams CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-03-04 15:39:38 EST
I'm guessing this is all packages, but I noticed in recent test of updating Java EE IDE from Helios SR1 to Helios SR2. 

I don't think I saw this during original testing, back in February, but maybe missed this path. 

The License for the "Java EE IDE Package" has a bunch of extra "\n\" at the end of lines, so shows up as a "different" license than the rest. First few lines are: 

ECLIPSE FOUNDATION SOFTWARE USER AGREEMENT\n\
June, 2010\n\
\n\


I know SR2 can't be fixed, but wanted to report, in case fixes needed for Indigo.
Comment 1 David Williams CLA 2013-04-11 16:41:08 EDT
Created attachment 229645 [details]
patch for all product definitions

These seems to still be a problem in Kepler. 

You can "see" it in the content.jar (search for June, 2010). 

You can also see it if you try to update from M5 to M6 Kepler. The easiest way to "prove" its EPP, is then it offers to update Java EE package, click next, and it shows you the feature/product that it will update. On that screen click "more" (with EPP one selected) and you can see the old license. 

Other packages, such as I checked Automotive, when you click "more" it shows "no license" ... which doesn't seem right. 

Elsewhere, the license shows up correctly, such as after installed. I think this is because the Eclipse UI has two "sources" of getting the license text. One is from the content.jar/xml file, the other is from the installed bundles/features after they are installed. So ... be be perfectly accurate, it must be defined (correctly) in both spots.
Comment 2 David Williams CLA 2013-04-11 16:42:13 EDT
If you agree Markus, I can probably commit what I have in my workspace ... just didn't want to do on my own, in case you think there is an easer solution.
Comment 3 David Williams CLA 2013-04-11 16:47:27 EDT
Oh, and once you actually get to the "license screen", when upgrading/installing Java EE from EPP, there is still at least one that shows the 

ECLIPSE FOUNDATION SOFTWARE USER AGREEMENT
June, 2010

Instead of 
Eclipse Foundation Software User Agreement
February 1, 2011

In this case, it's a little harder to know where the "old" license comes from, but it'd be nice to fix in EPP Java EE Product, and see if that was the (only) source.
Comment 4 Markus Knauer CLA 2014-05-08 13:34:03 EDT
I don't know why I didn't answer to this bug report yet...
Maybe it was fixed in earlier versions, too, but with this year's re-work for the new 2014 SUA this issue has been fixed for all packages.