Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338973 - Switch editor to using file service
Summary: Switch editor to using file service
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 15:26 EST by John Arthorne CLA
Modified: 2011-09-01 11:42 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-03-04 15:26:53 EST
The orion file service is now contributed by a plugin, which allows files to be served from a different server than the one providing the orion tools. To take advantage of this, the orion editor needs to use the file service to get/set editor contents.

As part of this, I propose axing the "ISaveable" service. This service doesn't represent a saveable entity like it does in Eclipse desktop. Instead it is a universal "saver" service that knows how to save arbitrary contents to arbitrary URLs. This really needs to be paired with the service that obtains contents for the editor. In the future we may have a need for a "saveable" abstract for things like writing subsets of files, writing objects that cross multiple files, etc. However, the current incarnation of the service doesn't address any of these needs.
Comment 1 John Arthorne CLA 2011-03-04 17:28:35 EST
Fix released.