Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338936 - Makefile parsers don't close the input streams
Summary: Makefile parsers don't close the input streams
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 7.0.3   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
: 365016 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-04 09:38 EST by Anton Leherbauer CLA
Modified: 2011-11-29 02:26 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2011-03-04 09:38:21 EST 
PosixMakefile.parse(URI, MakefileReader) and 
GNUMakefile.parse(URI, MakefileReader) 
both don't close the readers being given.
This leaves the makefiles open unless the streams are eventually finalized.
Comment 1 Anton Leherbauer CLA 2011-03-07 11:25:22 EST 
Fixed in HEAD and 7.0.2+
Comment 2 CDT Genie CLA 2011-03-07 12:38:28 EST 
*** cdt cvs genie on behalf of aleherbau ***
Bug 338936 - Makefile parsers don't close the input streams

[*] build.properties 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core.tests/build.properties?root=Tools_Project&r1=1.6&r2=1.7

[+] Makefile.main  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core.tests/data/Makefile.main?root=Tools_Project&revision=1.1&view=markup

[*] MakefileReaderProviderTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core.tests/src/org/eclipse/cdt/make/core/tests/MakefileReaderProviderTests.java?root=Tools_Project&r1=1.2&r2=1.3

[+] Makefile.incl  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core.tests/data/incl/Makefile.incl?root=Tools_Project&revision=1.1&view=markup

[*] GNUMakefile.java 1.21 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/makefile/gnu/GNUMakefile.java?root=Tools_Project&r1=1.20&r2=1.21

[*] PosixMakefile.java 1.22 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/makefile/posix/PosixMakefile.java?root=Tools_Project&r1=1.21&r2=1.22

[*] PosixMakefile.java 1.21.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/makefile/posix/PosixMakefile.java?root=Tools_Project&r1=1.21&r2=1.21.2.1

[*] GNUMakefile.java 1.20.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/makefile/gnu/GNUMakefile.java?root=Tools_Project&r1=1.20&r2=1.20.2.1

[*] build.properties 1.6.6.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core.tests/build.properties?root=Tools_Project&r1=1.6&r2=1.6.6.1

[*] MakefileReaderProviderTests.java 1.2.14.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.make.core.tests/src/org/eclipse/cdt/make/core/tests/MakefileReaderProviderTests.java?root=Tools_Project&r1=1.2&r2=1.2.14.1
Comment 3 Anton Leherbauer CLA 2011-11-29 02:26:21 EST 
*** Bug 365016 has been marked as a duplicate of this bug. ***