Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338868 - Import wizard should show p2 dependency resolution errors
Summary: Import wizard should show p2 dependency resolution errors
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Igor Fedorenko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 17:59 EST by Pascal Rapicault CLA
Modified: 2021-04-19 13:26 EDT (History)
2 users (show)

See Also:

Attachments
Modification for Import Wizard (38.45 KB, patch)
2011-03-08 10:36 EST, Matthew Piggott CLA 		no flags Details | Diff
Import Wizard Insallation Improvements (37.54 KB, patch)
2011-03-08 11:01 EST, Matthew Piggott CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2011-03-03 17:59:21 EST 
While selfhosting I ran into a situation where the elements selected from the store would not install because of dependency resolution errors with what is installed (this is expected).
Right now, such errors do not appear in the UI.
Comment 1 Pascal Rapicault CLA 2011-03-03 18:00:01 EST 
We can discuss it during the call.
Comment 2 Milos Kleint CLA 2011-03-07 03:39:21 EST 
aren't the dependency resolution problems rooted in wrong content of the m2e discovery repository? 

let's take an example of wtp. I assume that if wtp is not installed and we find the mapping in m2e discovery repository, we shall have everything in order to install it. If we don't, what is the point of showing the error? Maybe just not show anything? Or if we do have to show an error it should say: "You don't have WTP installed" or "For better web support, install WTP". "You have incompatible version of WTP".

But my fear is that the messages we have readily available are those long ones that mention Installable unit IDs and dependency versions. I don't consider these helpful. They will not fit inside the table, we will have to perform tricks on the UI to show the selected error in the page's header and it still won't fit. And the ui simplicity/consistency wil suffer.

on the technical side of things, where in the code are those messages stored?
Comment 3 Matthew Piggott CLA 2011-03-08 10:36:37 EST 
Created attachment 190665 [details]
Modification for Import Wizard

Unfortunately the messages are the p2 dependency errors, I don't believe we can do better.  Some of the errors can potentially be different library versions which may not be something we can present to the user.
Comment 4 Matthew Piggott CLA 2011-03-08 11:01:51 EST 
Created attachment 190666 [details]
Import Wizard Insallation Improvements

I accidentally included a change in the previous patch to point the discovery UI at a local site.
Comment 5 Igor Fedorenko CLA 2011-03-08 12:20:06 EST 
I pushed the patch with a trivial change (did not compile due to missing import) but this bug still needs some loving
Comment 6 Igor Fedorenko CLA 2011-03-09 22:20:54 EST 
I've change the import wizard to use MavenDiscoveryInstallOperation (in a not so nice wizard on top of wizard manner). This means that all p2 resolution is handles by the same code and GUI elements that are used by m2e marketplace and quick fixes, which presumably provides better error messages.
Comment 7 Denis Roy CLA 2021-04-19 13:26:41 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/