Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338826 - CompositeEditorFactoriesRegistry.getCompositeEditorFactory() should be parameterized
Summary: CompositeEditorFactoriesRegistry.getCompositeEditorFactory() should be parame...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 11:06 EST by Nicolas Guyomar CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: indigo+

Attachments
Patch for Bug 338826 (2.47 KB, patch)
2011-03-03 11:12 EST, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-03-03 11:06:34 EST 
Hi,

In order to avoid multiple compilation warnings, the method org.eclipse.emf.facet.widgets.celleditors.core.composite.registries.CompositeEditorFactoriesRegistry.getCompositeEditorFactory(Class<?>) should not use a wildcard, but a parameterized parameter.

Regards,
Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2011-03-03 11:12:32 EST 
Created attachment 190282 [details]
Patch for Bug 338826

Hi,

Please find attached the necessary code modifications so that the new method signature is : 
public <T> CompositeEditorFactory<T> getCompositeEditorFactory(final Class<T> type)

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-03-03 12:19:11 EST 
Comment on attachment 190282 [details]
Patch for Bug 338826


Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 336.
Comment 3 Gregoire Dupe CLA 2011-03-03 12:38:26 EST 
This bug can be marked as fixed.

Regards,
Gregoire
Comment 4 Gregoire Dupe CLA 2011-06-06 12:02:00 EDT 
This bug can be closed.