Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338816 - Resetting a perspective with multiple minimized stacks causes 'widget is disposed' errors
Summary: Resetting a perspective with multiple minimized stacks causes 'widget is disp...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.1 M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 09:43 EST by Eric Moffatt CLA
Modified: 2011-03-03 10:53 EST (History)
0 users

See Also:

Attachments
Defer the TrimBar layouts using 'asynchExec' (2.38 KB, patch)
2011-03-03 10:51 EST, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-03-03 09:43:29 EST 
Found when testing the new min/max work...

This is a bad one; open a fresh session, maximize the editor area and then reset the perspective...whamo !

The workbench is left in an unusable state...
Comment 1 Eric Moffatt CLA 2011-03-03 10:51:25 EST 
Created attachment 190278 [details]
Defer the TrimBar layouts using 'asynchExec'


The basic issue was that the TrimBarRenderer would attempt to layout every time one of its children was removed (removeGui calls 'hideChild'). This meant that while the 'resetPerspective' code was removing the trim associated with the perspective it was recursively calling the trimbar's layout...

This patch gathers up all the trim that needs to be adjusted and the layouts happen in a single, deferred, pass.
Comment 2 Eric Moffatt CLA 2011-03-03 10:53:00 EST 
Committed in >20110303. Applied the patch.