Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338811 - A model registration method in the interface ICatalogSetManager
Summary: A model registration method in the interface ICatalogSetManager
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 339255 339259
  Show dependency tree
 
Reported: 2011-03-03 08:50 EST by Nicolas Guyomar CLA
Modified: 2020-05-01 11:27 EDT (History)
2 users (show)

See Also:
gdupe: indigo+

Attachments
Patch Bug 338811 (2.88 KB, patch)
2011-03-03 08:53 EST, Nicolas Guyomar CLA 		no flags Details | Diff
Patch Bug 338811 (4.06 KB, patch)
2011-03-03 08:59 EST, Nicolas Guyomar CLA 		no flags Details | Diff
Patch Bug 338811 (5.22 KB, patch)
2011-03-08 08:04 EST, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
Patch Bug 338811 Common Core Utils (14.06 KB, patch)
2011-03-08 08:26 EST, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
org.eclipse.emf.facet.util.core plug-in initial contribution (14.46 KB, application/x-zip-compressed)
2011-03-08 10:12 EST, Gregoire Dupe CLA 		gdupe: iplog+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-03-03 08:50:42 EST 
Hi,

Regarding plug-in org.eclipse.emf.facet.util.emf.core :

catalogmanager and modeldeclaration extension point IDs should be visible so that anyone could programatically register.

This is for example used when creating a new Facet model, which is automatically registered as a modelDeclaration.

Regards,
Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2011-03-03 08:53:09 EST 
Created attachment 190267 [details]
Patch Bug 338811

Please find attached a patch which moves the ID declaration in there respective interface ICatalogManager and ICatalogSetManager


(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 2 Nicolas Guyomar CLA 2011-03-03 08:59:16 EST 
Created attachment 190270 [details]
Patch Bug 338811

Hi,

I have added usual copyrights in the three modified Java classes.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 3 Gregoire Dupe CLA 2011-03-08 05:45:51 EST 
Hi,

To my mind, instead of expose IDs, we should offer a model registration method in the interface ICatalogSetManager. This method would have the following signature:

public void registerFacetSetDeclaration(IFile file) throw InvalidFacetSetException;

Regards,
Grégoire
Comment 4 Nicolas Guyomar CLA 2011-03-08 08:04:14 EST 
Created attachment 190652 [details]
Patch Bug 338811

Hi,

Please find attached the registration service implementation.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 5 Nicolas Guyomar CLA 2011-03-08 08:26:31 EST 
Created attachment 190656 [details]
Patch Bug 338811 Common Core Utils

Hi,

Please find attached a patch on org.eclipse.emf.facet.common.core which contains some additional classes copied from org.eclipse.emf.facet.infra.common.core.
Author is Nicolas Bros, commiter

Regards,
Nicolas Guyomar
Comment 6 Gregoire Dupe CLA 2011-03-08 08:43:55 EST 
Comment on attachment 190656 [details]
Patch Bug 338811 Common Core Utils


Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 340.
Comment 7 Gregoire Dupe CLA 2011-03-08 08:48:10 EST 
Comment on attachment 190652 [details]
Patch Bug 338811


Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 341.
Comment 8 Gregoire Dupe CLA 2011-03-08 10:12:27 EST 
Created attachment 190663 [details]
org.eclipse.emf.facet.util.core plug-in initial contribution

The utility classes BuildPropertiesUtils and PluginUtils have to be stored in the plug-in org.eclipse.emf.facet.util.core.

Here is the initial contribution of this plug-in.
Comment 9 Gregoire Dupe CLA 2011-03-08 10:33:04 EST 
Comment on attachment 190663 [details]
org.eclipse.emf.facet.util.core plug-in initial contribution

The classes contained in this plug-in are copied from the EMF Facet project.

I've commited this plug-in.

Committed revision 343.
Comment 10 Gregoire Dupe CLA 2011-03-08 12:33:49 EST 
I've marked has deprecated the moved classes (BuildPropertiesUtils and PluginUtils).

Regards,
Gregoire
Comment 11 Gregoire Dupe CLA 2011-06-08 09:26:01 EDT 
This bug can be closed.