Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338764 - [client] on navigate-table.html, splitter moves to the right on subsequent page visits
Summary: [client] on navigate-table.html, splitter moves to the right on subsequent pa...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 21:35 EST by Boris Bokowski CLA
Modified: 2011-09-01 11:42 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2011-03-02 21:35:16 EST
I don't have reproducible steps, but on Chrome (Mac) I keep having to move the splitter back to the left. Something going on with persisting the widths?
Comment 1 Susan McCourt CLA 2011-03-03 11:08:09 EST
I'll try to get this for M6
Comment 2 Susan McCourt CLA 2011-03-04 11:04:37 EST
the favorites are also rendering beyond the split.  The split is appearing in a different place than the actual window border. I think that's the fundamental problem.

I haven't made any changes in this area, sounds like my chance to learn git bisect.
Comment 3 Susan McCourt CLA 2011-03-07 12:16:30 EST
Boris, are you still seeing this problem?
It seemed much worse to me when you first reported it.  I was observing stuff rendering past the splitter and splitter moving progressively rightward.

Today, I observe this:
- open a navigator
- open a second navigator
- adjust the split of the first one
- now if you refresh the page of the second one, the split is moved (due to the user setting).

But if I just adjust the split on the second navigator before refreshing, all is well, since the new value is saved.  This doesn't seem critical for M6, so removing milestone.
Comment 4 Susan McCourt CLA 2011-03-09 13:09:50 EST
I just started using git-status and now I see this all the time!
It seems those two pages are sharing the splitter setting.
Since you need a much wider left pane for git-status, you'll always be annoyed when you go to navigator from git-status.

I will investigate.
Comment 5 Boris Bokowski CLA 2011-03-09 13:55:39 EST
aha, finally an explanation! :-)
Comment 6 Susan McCourt CLA 2011-03-09 16:35:44 EST
fixed.
This one was interesting.  dojo saves the splitter info in a cookie, generating a cookie name which is:

containerid + position

And...dojo generates ids for dom elements that don't have one assigned.  It uses instance counting to ensure that element ids are unique per page, but it can't ensure that the ids are unique across pages.

So we had all the same cookie due to the same position of splitter and same autogenerated id name.