Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338759 - The 'Suspend all validators' checkbox under Window > Preferences > Validation does not suspend validators
Summary: The 'Suspend all validators' checkbox under Window > Preferences > Validation...
Status: NEW
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.validation (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows 7
: P3 normal with 7 votes (vote)
Target Milestone: ---   Edit
Assignee: wst.validation CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 18:40 EST by Richard Kennard CLA
Modified: 2016-11-29 09:24 EST (History)
14 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Kennard CLA 2011-03-02 18:40:23 EST
Build Identifier: Version: Helios Service Release 1. Build id: 20100917-0705

In previous releases of Eclipse, clicking 'Suspend all validators' would grey out and disable all validators listed below. In 3.6.2 the list is greyed out, but the validators still seem to run.

Reproducible: Always

Steps to Reproduce:
Assuming you have a project that has 'Missing semicolon' JavaScript errors:

1. Go into Window > Preferences > Validators
2. Turn 'Suspend All Validators' off
3. Choose 'Enable All'
4. Turn 'Suspend All Validators' on
5. Recompile your project. Note validation errors (even though validators are supposed to be suspended)
6. Go back into Window > Preferences > Validators
7. Turn 'Suspend All Validators' off
8. Choose 'Disable All'
9. Turn 'Suspend All Validators' on
10. Recompile your project. Note validation errors are still there (weird!)
11. Go back into Window > Preferences > Validators
12. Turn 'Suspend All Validators' off
13. Recompile your project. Note validation errors are gone

See also: http://kennardconsulting.blogspot.com/2011/03/eclipse-helios-missing-semicolon.html
Comment 1 Frank Henningsen CLA 2011-09-01 05:17:56 EDT
My problem panel consistently displays a XML Problem: 
"Referenced file contains errors (http://www.jayasoft.org/misc/ivy/ivy.xsd)."
which i dont want to know about, so i've been trying to disable all my XML validators using the "Suspend All Validator" checkbox, but it does not seem to work.
Comment 2 Vladimir Nicolici CLA 2012-01-04 04:15:19 EST
I have a similar problem, but it only applies to the JavaScript validator, I am not able to disable JavaScript validation at all.

I tried anything I could think of. Disable it at project level. Disable it globally. Suspend all validators at project level, suspend them globally, add the directory with the problem files to an Exclude group for the JavaScript validator, cleaning the project, rebuilding the project, closing / reopening the project, disabling JavaScript semantic validation. Nothing works.

Setting the directory as derived seemed reduced the number of errors and warnings, but thousands still remain.

Using Indigo Service Release 1, m2e 1.0.100, Subversive 2.2.2 on Windows 8 Developer Preview.
Comment 3 Jon Seymour CLA 2012-01-29 08:24:30 EST
I have experienced this problem with the JavaScript validators in IBM RSA 8.0.4.

The issue appears to be that by default a Dynamic Web Project is configured with a builder called "JavaScript Validator" and this builder runs irrespective of the configuration of the suspend all validators setting.

I found that by disabling that builder (or by removing it completely, by editing the .project file) it is possible to avoid the JavaScript validation cost on every build.
Comment 4 Jon Seymour CLA 2012-01-29 08:41:52 EST
This page may also be of some use: http://goo.gl/q6GTc
Comment 5 Mauro Molinari CLA 2012-01-31 03:19:56 EST
Is this really a bug? Isn't the observed behaviour due to the fact that JSDT does not use the Validation framework? See bug 362250 comment 1.
Comment 6 Joerg Hohwiller CLA 2014-01-28 05:57:24 EST
(In reply to Mauro Molinari from comment #5)
> Is this really a bug?

Absolutely. Eclipse has Validators and there is currently no way to disable them. 1. If you do not want to have them, they waste a lot of performance making you wait
2. They produce false positives (esp. in JavaScript but also e.g. if you have a file *.html in your project is does not mean that this is a plain HTML file for the browser but it might also be a template with server-side markup, etc.)
As a result the project is marked with errors so you think that the build is broken. If you are "getting used" to having errors, you start missing the real errors.

For 2. there is a (nasty) workaround as described by Jon but for 1. there is no solution available.
If Eclipse already offers a feature in the UI to suspend single validators or all of them these feature should not only be a UI gimmick with no effect on the actual validation.
It would be lovely to see this properly implemented in a new eclipse release.
Comment 7 Davide Perini CLA 2014-06-26 05:49:34 EDT
It seems incredible.
We have this problems since years and Luna continues to validate javascript file and XML POM.

The eclipse project is slowly dying without IBM.
Comment 8 Stijn de Witt CLA 2015-06-15 18:28:40 EDT
Yup. Sad but true.

What they should do is a spring cleaning of sorts. Back to basics.
I just struggled for over half an hour, because I added a library with a lot of JS in it to my project which had the Javascript Validator in the builder config. The project was set to be built automatically, but this failed causing Eclipse to crash with out of memory. Then when it starts again it tries to build again... and crashes again. Argh!

Please just remove the Javascript Validation builder from Eclipse as in its current form it is unusable and hurts more than it helps.
Comment 9 Jörg Hohwiller CLA 2016-09-13 16:11:29 EDT
> Please just remove the Javascript Validation builder from Eclipse as in its current form it is unusable and hurts more than it helps.

Jep. Totally right point.
Todays JS projects have node_modules folder which is like maven repository a extraordinary large folder. Eclipse should not care about this stuff at all.
Instead it blocks for hours scanning, indexing and validating all this.
Validation causes tons of false positives. In many cases it will also crash due to out of memory. Removing all this crap from Eclipse will actually make Eclipse much better.
Comment 10 Nitin Dahyabhai CLA 2016-09-13 19:01:55 EDT
(In reply to Jörg Hohwiller from comment #9)
Which release are *you* using?
Comment 11 Jörg Hohwiller CLA 2016-11-01 03:42:26 EDT
I am using Eclipse Mars.2 but I also have a Neon installed. I will also test angular projects with Neon and let you know if that is better now.
Comment 12 Jörg Hohwiller CLA 2016-11-01 04:19:31 EDT
Version: Neon.1a Release (4.6.1)
Build id: 20161007-1200

With this version you can at least import bigger JS projects without Eclipse crashing. However, as a test I imported 4 projects with Java and JS/TS code. It took 12 minutes (Lenovo ThinkPad T550) until the build was complete and Eclipse was "usable" again. Most of the time Eclipse showed "Checking files..." in the lower right status bar.

SLOC for the 4 projects
1.  1.552 SLOC
2.  8.002 SLOC
3. 61.113 SLOC
4. 14.672 SLOC

So with Neon it is now "possible" to develop on such projects. However, my expectation of performance and development speed is still not satisfied. This is just too slow. Maybe introduce simple workarounds such as a feature to configure Eclipse to ignore specific folders like "node_modules" entirely. IMHO very easy to implement but high value in such cases.

BTW: I contributed to many OSS projects when I was not happy with the result. However, for Eclipse the entrance barrier is IMHO too high. All this OSGi stuff, finding the right module and code where to start looking and especially the inability to simply test things isolated with JUnit is keeping me from getting started at all. Also the instructions for developers are poor. So unfortunately I will only keep complaining. Sorry.
Comment 13 Jörg Hohwiller CLA 2016-11-01 04:36:04 EDT
However, what I forgot to mention in all my criticism:
Eclipse Neon did not complain about validation errors in JS and HTML files. I can not tell exactly as I might have removed some of the responsive JS validation plugins as this issue was so annoying that I tried every possible workaround.
At least in Preferences > Validation there are only 8 validators shown and none of them is related to JS, CSS or HTML.
I can not tell right now if that would also be the case in a vanilla Neon. If so then this is already a really big step ahead for the actual problem reported with this bug ticket.
Comment 14 Jörg Hohwiller CLA 2016-11-01 04:40:56 EDT
But before anyone is tempted to just close this issue:
When I disable "Suspend all validators" and wait until the full rebuild has completed and then go back and re-enable "Suspend all validators" then Eclipse Neon is busy for 3-4 Minutes showing "Validation (x%)". So the actual issue is still unchanged. The checkbox "Suspend all validators" is not honored by any feature in the validation implementation. It is just a pointless UI widget.
I do not know about the internas of Eclipse in this area. But can it be so hard to properly implement this within 5 years?