Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338725 - @Basic should not be added to attributes
Summary: @Basic should not be added to attributes
Status: CLOSED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 0.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Petya Sabeva CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard:
Keywords: plan
Depends on: 325531
Blocks:
  Show dependency tree
 
Reported: 2011-03-02 15:03 EST by Shaun Smith CLA
Modified: 2012-10-03 02:40 EDT (History)
3 users (show)

See Also:
stefan.dimov: review+

Attachments
patch (1.05 KB, patch)
2011-05-10 10:27 EDT, Petya Sabeva CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Smith CLA 2011-03-02 15:03:19 EST 
In Bug 325531, comment 5 Stefan correctly indicates that @Basic should not be added when unnecessary.  The fix for Bug 325531 only addressed the import problem and not the unnecessary @Basic.
Comment 1 Petya Sabeva CLA 2011-05-10 10:27:56 EDT 
Created attachment 195221 [details]
patch
Comment 2 Stefan Dimov CLA 2011-05-10 12:11:40 EDT 
The bug is not a big deal, but also is the fix. This one stayed open for a long time and now it has a fix. 

The bug does not need workaround because it's about creating a new basic attribute without the redundant @Basic annotation.

The fix is trivial - just a string parameter changed from "@Basic" to "". I've reviewed it and I think it's ok. I've tested it manually. 

The risk is low.
Comment 3 Neil Hauge CLA 2011-05-10 13:17:50 EDT 
I don't think I can make a case for this as an important bug fix for RC1 since it is more of an issue of preference, although I would suspect most would prefer to not insert the basic annotation into the code.  I will leave this targeted to 3.1 for now.  If someone would like to argue for inclusion into RC1, please do so here so it can be documented for PMC review.
Comment 4 Stefan Dimov CLA 2011-05-10 13:24:40 EDT 
(In reply to comment #3)

Just one note:

> ... although I would suspect most would
> prefer to not insert the basic annotation into the code

That's exactly what the fix is about. With it, when a new attribute is created the @Basic annotation is NOT being inserted into the code ...
Comment 5 Neil Hauge CLA 2011-10-27 11:16:35 EDT 
The 3.2 target now represents the Juno release.
Comment 6 Petya Sabeva CLA 2012-05-04 02:02:46 EDT 
Retargeting this bug to the Kepler realease (3.3).
Comment 7 Petya Sabeva CLA 2012-09-18 04:07:16 EDT 
The Basic annotation is removed with the following git commit:

http://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=387e840daab9cab568e723283ceda994db8c9b58

The change still needs to be released.
Comment 8 Petya Sabeva CLA 2012-10-03 02:40:24 EDT 
Changes are released...