Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338712 - Default Table Names prefix should be null
Summary: Default Table Names prefix should be null
Status: CLOSED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Petya Sabeva CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2011-03-02 13:04 EST by Shaun Smith CLA
Modified: 2012-10-03 02:39 EDT (History)
1 user (show)

See Also:
stefan.dimov: review+

Attachments
patch (1.33 KB, patch)
2011-05-10 10:28 EDT, Petya Sabeva CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Smith CLA 2011-03-02 13:04:01 EST 
Newly created classes are mapped to tables beginning with the default prefix "T_".  The default table name should use the JPA default which is the entity name therefore the prefix default should be "". 

The project default prefix can be specified but a workspace wide default should also be available.
Comment 1 Petya Sabeva CLA 2011-05-10 10:28:27 EDT 
Created attachment 195223 [details]
patch
Comment 2 Stefan Dimov CLA 2011-05-10 13:19:13 EDT 
The bug is trivial.

It has an easy workaround, because the default table prefix could be easily changed, but this bug stays open for a long time and perhaps it's annoying for the users.

The fix is tested manually. All the existing JUnit tests are passing successfully.

The default table name prefix in the editor is defined in a single hardcoded constant. That is the actual change - the constant is changed from "T_" to "".
I've reviewed the fix and it's ok.

The risk is low.
Comment 3 Neil Hauge CLA 2011-05-10 13:57:54 EDT 
While I agree with the fix, I don't think this quite meets the qualifications of an RC1 fix candidate.  Leaving targeted to 3.1.
Comment 4 Neil Hauge CLA 2011-10-27 11:16:43 EDT 
The 3.2 target now represents the Juno release.
Comment 5 Petya Sabeva CLA 2012-05-04 02:01:58 EDT 
Retargeting this bug to the Kepler realease (3.3).
Comment 6 Petya Sabeva CLA 2012-09-18 04:04:45 EDT 
Changes are committed in the master branch of git with the following git commit:

http://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=474818faab56cf761430a89c7fb7e47be39bf93c

Change still needs to be released.
Comment 7 Petya Sabeva CLA 2012-10-03 02:39:45 EDT 
Changes are released...