Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338652 - [server] Timeouts on POST /git/clone
Summary: [server] Timeouts on POST /git/clone
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 334140 337818
Blocks:
  Show dependency tree
 
Reported: 2011-03-02 06:58 EST by Szymon Brandys CLA
Modified: 2011-09-01 11:42 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-03-02 06:58:06 EST 
Cloning a git repo may be a long-running operation. Recently if the operation lasts longer than 15 sec, we may see timeouts on the console and the user does not know whether the operation is finished or not. We should handle it better.

The approach for now is to return ACCEPT immediately on POST /git/clone. The response should contain the location of the clone resource. We may then start calling GET on the location to see if the repo is in a consistent state.

In the future we should use a mechanism for reporting progress of long-running operations. See 334140.
Comment 1 Tomasz Zarna CLA 2011-03-07 05:40:11 EST 
This will apply to all long running operations in git: fetching in general and pushing. No bugs for these two yet, but they were already mentioned on bug 336116.
Comment 2 Tomasz Zarna CLA 2011-04-12 05:22:49 EDT 
John has added reporting progress on git clone[1]. I'm leaving this bug open as we will still get timeouts on fetch[2] and pull[3] (once they're ready).

[1] http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=5bee150d470fbd760dcb34703b13b472d9198212
[2] bug 339110
[3] bug 339114
Comment 3 John Arthorne CLA 2011-04-12 10:00:53 EDT 
I have some client-side changes for git clone coming as well, hopefully today or tomorrow. It's only a change of a few lines in gitCommands.js. Most of the code is in a separate piece for reporting progress. I'm just working out some bugs now. Hopefully this can be reused for the other long-running git commands as well.
Comment 4 John Arthorne CLA 2011-04-12 16:42:26 EDT 
I have pushed by changes for git clone:

http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=f6729ecf8cf60e5f558fe95b2c21b7be1fa752a7

http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=f9e22cca7a85230b7ec292c821ff479769ff4d16

The progress messages aren't showing, but I verified that the basic workflow works. A clone request is POSTed, then the client waits for the progress to indicate completion, and finally the dialog opens showing the location of the cloned repository. I found the e4 "deeplink" repository is a good test case because the repo is very small:

http://git.eclipse.org/c/e4/org.eclipse.e4.deeplink.git/
Comment 5 Szymon Brandys CLA 2011-04-12 18:03:28 EDT 
Thanks John. I will try to use it for Fetch command and see if I can find any issues with it.
Comment 6 Szymon Brandys CLA 2011-04-19 11:22:47 EDT 
John fixed the issue in Git Clone by using the progress service there.