Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338636 - some cell editors need an initial value
Summary: some cell editors need an initial value
Status: CLOSED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 04:51 EST by Nicolas Bros CLA
Modified: 2020-05-01 11:26 EDT (History)
3 users (show)

See Also:

Attachments
patch (11.20 KB, patch)
2011-03-02 05:36 EST, Nicolas Bros CLA 		gdupe: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-03-02 04:51:17 EST 
Add a context parameter to createCompositeEditor in org.eclipse.emf.facet.widgets.celleditors.core.composite.CompositeEditorFactory<T>.
Comment 1 Nicolas Bros CLA 2011-03-02 05:36:15 EST 
Created attachment 190125 [details]
patch
Comment 2 Fabien Giquel CLA 2011-03-02 07:30:35 EST 
Hi Nicolas,

after internal debate about this evolution, it seems better to provide some 'T initialValue' parameter rather than 'Object context'.

The client is in charge of building the initialValue contextually to its needs. Neither the "CompositeEditorFactory" sublass nor the T class have to know how to process a context.
Comment 3 Nicolas Bros CLA 2011-03-02 09:57:27 EST 
There is no need to change anything on the EMF Facet side. 
When used in a JFace context, the framework initializes the cell editor's value with the value it gets from the EditingSupport.
Comment 4 Gregoire Dupe CLA 2012-05-23 08:13:52 EDT 
This bug can be closed.