Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338630 - Dnd-ing a project does not republish it
Summary: Dnd-ing a project does not republish it
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.2.4   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 04:11 EST by Krzysztof Daniel CLA
Modified: 2017-10-11 16:36 EDT (History)
1 user (show)

See Also:

Attachments
Trivial fix proposition (2.34 KB, patch)
2011-03-16 04:49 EDT, Krzysztof Daniel CLA 		arvera: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2011-03-02 04:11:31 EST 
org.eclipse.wst.server.ui.internal.cnf.ServersViewDropAdapterAssistant.doRunOnServerAction(IServer, Object) breaks the flow if project has been already published.

if (ServerUtil.containsModule(server, parents[0], null))
						return false;

It should do a republish instead.
Comment 1 Krzysztof Daniel CLA 2011-03-04 02:21:08 EST 
Further investigation revealed that DnDing a project does not cause republish to happen. It is just a configuration. It is expected that a publish will also happen.

(Note that republish will not happen if you do not have enabled automatic publish after resource change).
Comment 2 Krzysztof Daniel CLA 2011-03-14 09:35:02 EDT 
Tim,
do you think we could implement something like this?
Comment 3 Angel Vera CLA 2011-03-14 10:11:17 EDT 
Hi Christophe, 

I would expect the DND to have the same behaviour as the right click Run As > Run on Server. Are you saying that they are not the same?
Comment 4 Krzysztof Daniel CLA 2011-03-14 17:26:57 EDT 
That's the problem. If you disable the auto publish you will see.
Comment 5 Krzysztof Daniel CLA 2011-03-16 04:49:03 EDT 
Created attachment 191283 [details]
Trivial fix proposition
Comment 6 Krzysztof Daniel CLA 2011-04-06 02:45:03 EDT 
Angel, are there any plans about this bug?
Comment 7 Angel Vera CLA 2011-04-06 16:50:24 EDT 
Changes committed to 32M
Comment 8 Angel Vera CLA 2011-04-06 16:54:40 EDT 
changes released to 32M
Comment 9 Angel Vera CLA 2011-04-19 11:42:22 EDT 
changes committed to HEAD(3.3)
Comment 10 Angel Vera CLA 2011-04-19 15:35:42 EDT 
Changes released to HEAD(3.3)
Comment 11 Eclipse Genie CLA 2017-10-11 16:36:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/109040