Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338615 - com.goole.gwtjsonrpc, com.google.gwtorm, com.google.gerrit.* should have execution environment set to 1.6
Summary: com.goole.gwtjsonrpc, com.google.gwtorm, com.google.gerrit.* should have exec...
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: Indigo M6   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 338616
  Show dependency tree
 
Reported: 2011-03-01 22:22 EST by Steffen Pingel CLA
Modified: 2011-03-02 18:36 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-03-01 22:22:46 EST 
It appears that classes in these bundles where compiled against 1.6 and hence the execution environment should be updated:

 com.goole.gwtjsonrpc
 com.google.gwtorm
 com.google.gerrit.common
 com.google.gerrit.prettify
 com.google.gerrit.reviewdb

Not sure if 1.6 is strictly necessary but the original libraries specify that in their poms and we would need to recompile classes to make the bundles work on 1.5.
Comment 1 Shawn Pearce CLA 2011-03-02 11:27:17 EST 
(In reply to comment #0)
> Not sure if 1.6 is strictly necessary but the original libraries specify that
> in their poms and we would need to recompile classes to make the bundles work
> on 1.5.

We might be able to rebuild these using Java 5. There were some APIs we needed in Gerrit that forced us to require Java 6... but I think those are all on the server. The only problem with the client side might be using String.isEmpty() rather than String.length() == 0. Those can be easily fixed by hand and submitted back upstream. But keeping them out might be harder. :-)
Comment 2 David Williams CLA 2011-03-02 11:34:37 EST 
> We might be able to rebuild these using Java 5. 

In general, this wouldn't be required unless someone (some client, or adopter) has that specific need. As a whole, Indigo release will required Java 6, so I don't think we need to do it just to do it. 

But ... EE should definitely be accurate.
Comment 3 David Williams CLA 2011-03-02 12:45:06 EST 
Chris, I think these are "yours"? Seems M6 would be nice if you can fix (and agree with the fix) in next day or two. 

Thanks,
Comment 4 Chris Aniszczyk CLA 2011-03-02 18:36:37 EST 
Done, tagged as v201103020530.