Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338608 - [client] tree/table setting doesn't "stick" anymore
Summary: [client] tree/table setting doesn't "stick" anymore
Status: CLOSED INVALID
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 19:13 EST by Susan McCourt CLA
Modified: 2011-08-30 10:32 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-03-01 19:13:55 EST
I'm not sure when this broke, but we used to store the user's preference for table or tree view to the preferences, and index.html would direct to the appropriate place.  Now it seems that index.html always goes to the table view regardless of your last view.  Not sure if the problem is that storing it broke, or that reading it broke.
Comment 1 Boris Bokowski CLA 2011-03-01 19:56:32 EST
(In reply to comment #0)
> I'm not sure when this broke, but we used to store the user's preference for
> table or tree view to the preferences, and index.html would direct to the
> appropriate place.  Now it seems that index.html always goes to the table view
> regardless of your last view.  Not sure if the problem is that storing it
> broke, or that reading it broke.

I changed index.html to always go to the table view. This was to fix the "double login dialog" problem - we brought up the login dialog (first instance) and concurrently started looking at the preference for whether to go to tree or table. In the not-logged-in case, this caused an error response, which in turn caused us to go to the table page. On this page, the user was still not logged in (unless they were really fast in filling the first login dialog), so we opened another login dialog (second instance).

The proper solution would be to wait on index.html until the user was successfully logged in, then accessing the preference, and then going to the table or tree page.
Comment 2 Boris Bokowski CLA 2011-03-01 19:57:39 EST
Who still uses the tree page? ;-)
Comment 3 Susan McCourt CLA 2011-03-02 11:50:28 EST
(In reply to comment #2)
> Who still uses the tree page? ;-)

;-)
I do, but only to make sure it still mostly works.  It's also our answer to "table tree is not fully keyboard enabled or accessible."  It also helps me ensure the command framework can deal with very different rendering of commands that have been declared in a common place.

But I agree, maybe having a dynamic view switch and exposing all that to the user is not very interesting.
Comment 4 Susan McCourt CLA 2011-03-03 17:44:53 EST
for M6 I've removed the "switch view" command on nav-table.
We can revisit this later.
Comment 5 Mark Macdonald CLA 2011-06-13 17:32:27 EDT
The tree view is gone so this is not an issue anymore.