Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338498 - [client] blue dojo styling for "More" menu looks out of place
Summary: [client] blue dojo styling for "More" menu looks out of place
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 21:45 EST by Boris Bokowski CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:

Attachments
screen shot (56.03 KB, image/png)
2011-02-28 21:45 EST, Boris Bokowski CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2011-02-28 21:45:27 EST 
Would it be hard to style it differently (e.g. with some kind of gray)? Also (on Chrome/Mac), the drop down menu is missing the bottom and right border.
Comment 1 Boris Bokowski CLA 2011-02-28 21:45:43 EST 
Created attachment 190012 [details]
screen shot
Comment 2 Susan McCourt CLA 2011-03-01 16:48:42 EST 
these are the kind of changes I'm hoping to make next week (when feature complete.)  I'd like to see the menu get a border around it on hover rather than change color (so it always just blends into its surroundings.)  I'll have to play with it and see...
Comment 3 Susan McCourt CLA 2011-03-08 17:07:26 EST 
fixed.
per Linda's mockups, menu buttons hover a light gray, and the items will hover/select with an orange color.  (Her mockup called for a gray border around a hovering drop down button, but this caused the layout to jump horizontally by the 2 pixels used on each side, so I didn't add a border.)

Note that I fixed this for the menus used in the command framework.  I didn't make a general fix for all dojo buttons, so if there are places where push buttons are used, they will still have the blue.  I wasn't sure how far to take the restyling, I think the goal is that we'd get rid of the dojo buttons and use commands instead.
Comment 4 Susan McCourt CLA 2011-03-08 17:39:29 EST 
(In reply to comment #3)
> I didn't
> make a general fix for all dojo buttons, so if there are places where push
> buttons are used, they will still have the blue.  I wasn't sure how far to take
> the restyling, I think the goal is that we'd get rid of the dojo buttons and
> use commands instead.

Felt bad about this and figured out how to generalize the styling.  All buttons (AFAICT) now hover gray.  A border would look nice but the layout issues would have to get figured out (like including a border the same color as background on the non-hover state)