Community
Participate
Working Groups
When a project configuration needs to be updated, an error marker is being created on the project. Several comments: - Should the error be located on the pom instead of the project? - Should there be a quick fix to allow the user to resolve the problem?
Note that we also talked about having a preference that would automatically trigger the project configuration upon changes, so it may be an argument to not do much on this and rather solve the other issue.
(In reply to comment #0) > When a project configuration needs to be updated, an error marker is being > created on the project. > Several comments: > - Should the error be located on the pom instead of the project? We discussed this with Milos. This is not a problem with pom.xml, so we decided project was more appropriate location for this marker. > - Should there be a quick fix to allow the user to resolve the problem? Yes, quick-fix is a good idea. (In reply to comment #1) > Note that we also talked about having a preference that would automatically > trigger the project configuration upon changes, so it may be an argument to not > do much on this and rather solve the other issue. Automatic project configuration update is a hard problem to solve. We need to account for any possible manual changes to project configuration. Dealing with major project configuration changes (eg, packaging war->eclipse-plugin) requires working implementation of #unconfigure, which is not there. Also, changes that require configuration update are relatively infrequent, so I think it may be good enough just to show the update is required.
In the netbeans codebase, I've done automatic project configuration updates. Not entirely transferable here but here's how it worked for reference: 1. on IDE start all opened projects loaded (a necessary step as there is no other model than the POM) 2. on settings.xml file changes, all opened projects reload. 3. on pom.xml file change, the respective project reloads. AFAIK I never gone as far as updating all child projects when a parent changes.. not sure though.. 4. There is still a "Refresh" action on the project's popup menu, so if users detect a problem, they can fix it. Didn't get any complaints for this setup. Maybe I would if I removed the Refresh button :)
*** Bug 340095 has been marked as a duplicate of this bug. ***
(In reply to comment #4) > *** Bug 340095 has been marked as a duplicate of this bug. *** since the 340095 is marked as duplicate, are we in agreement that the fix to this issue is the addition of quick fix ?
Yes. Lets do quick-fix now and re-evaluate if we need anything more elaborate based on user feedback later.
http://git.eclipse.org/c/m2e/m2e-core.git/commit/?h=milos_m7_buffer&id=468d6ebccf45cf0fc61d5c0597c7ca475c17dd58 implements the quickfix, not in master yet.
in master now
Moved to https://github.com/eclipse-m2e/m2e-core/issues/
