Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338484 - Provide enablement expression to ModuleFactory used by Java EE tools
Summary: Provide enablement expression to ModuleFactory used by Java EE tools
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.4   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 18:06 EST by Roberto Sanchez Herrera CLA
Modified: 2011-03-28 11:00 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
Provide enablement to org.eclipse.wst.server.core.moduleFactories (2.58 KB, patch)
2011-03-07 13:16 EST, Roberto Sanchez Herrera CLA 		no flags Details | Diff
Updated patch (2.59 KB, patch)
2011-03-07 17:41 EST, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2011-02-28 18:06:10 EST 
Build Identifier: WTP 3.2.4

This is more an enhancement than a defect. As part of bug 333617, an enablement expression was added to ModuleFactory extension point to prevent early loading of factories that are in use. This bug is to use that enablement expression in the ModuleFactory extension in Java EE tools code. 

Reproducible: Always
Comment 1 Roberto Sanchez Herrera CLA 2011-03-07 13:16:49 EST 
Created attachment 190580 [details]
Provide enablement to org.eclipse.wst.server.core.moduleFactories
Comment 2 Chuck Bridgham CLA 2011-03-07 14:06:03 EST 
Quick question....   didn't we have a separate module factory for EE5?

Can this class handle all EE5/5 model api's etc?
Comment 3 Roberto Sanchez Herrera CLA 2011-03-07 17:41:56 EST 
Created attachment 190606 [details]
Updated patch

Updated patch: the EE5 and EE6 module factory should accept EAR 5 and 6 facets only.
Comment 4 Roberto Sanchez Herrera CLA 2011-03-07 17:42:28 EST 
(In reply to comment #2)
> Quick question....   didn't we have a separate module factory for EE5?
> 
> Can this class handle all EE5/5 model api's etc?

The patch includes changes for the legacy module factory (in org.eclipse.jst.j2ee) and for the EE5 and EE6 module factory (in org.eclipse.jst.jee)
Comment 5 Chuck Bridgham CLA 2011-03-17 10:47:38 EDT 
approved
Comment 6 Carl Anderson CLA 2011-03-28 11:00:21 EDT 
Committed to R3_2_maintenance and HEAD for WTP 3.2.4 and WTP 3.3 M7