Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338453 - Jump to location does not work for pom. and project. properties
Summary: Jump to location does not work for pom. and project. properties
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 14:41 EST by Pascal Rapicault CLA
Modified: 2021-04-19 13:26 EDT (History)
2 users (show)

See Also:

Attachments
screenshot of the problem. (57.68 KB, image/png)
2011-02-28 14:41 EST, Pascal Rapicault CLA 		no flags Details
pom with the problem (10.71 KB, text/xml)
2011-02-28 14:42 EST, Pascal Rapicault CLA 		no flags Details
Locate project.version and project.name (3.03 KB, patch)
2011-02-28 17:12 EST, Matthew Piggott CLA 		no flags Details | Diff
Disable hyperlink for unknown (7.76 KB, patch)
2011-03-07 10:00 EST, Matthew Piggott CLA 		no flags Details | Diff
Fixed disable hyperlink patch (7.85 KB, patch)
2011-03-07 12:43 EST, Matthew Piggott CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2011-02-28 14:41:49 EST 
Created attachment 189984 [details]
screenshot of the problem.

I have a dependency defined in the dependency management section of the pom. This dependency uses a variable to identify the version to be used.
When I hover over the element, I get a "jump to location" link but it does not work. Attached is a screenshot of the situation and the pom.
Comment 1 Pascal Rapicault CLA 2011-02-28 14:42:40 EST 
Created attachment 189985 [details]
pom with the problem
Comment 2 Matthew Piggott CLA 2011-02-28 15:50:27 EST 
Looking at this
Comment 3 Matthew Piggott CLA 2011-02-28 17:12:41 EST 
Created attachment 190002 [details]
Locate project.version and project.name
Comment 4 Milos Kleint CLA 2011-03-01 03:25:10 EST 
we should not identify expressions starting with "project." and "pom." as hyperlink-able.
Comment 5 Pascal Rapicault CLA 2011-03-01 09:01:48 EST 
(In reply to comment #4)
> we should not identify expressions starting with "project." and "pom." as
> hyperlink-able.
   Could you explain why? At first this sounded like a good idea :)
Comment 6 Milos Kleint CLA 2011-03-01 09:51:20 EST 
(In reply to comment #5)
> (In reply to comment #4)
> > we should not identify expressions starting with "project." and "pom." as
> > hyperlink-able.
>    Could you explain why? At first this sounded like a good idea :)

what I meant is that we shall not have hyperlink available for something we don't support.

project. and pom. and reflective meta properties derived from the pom model, sometimes the value is not really defined anywhere (but the superpom).. think project.build.outputDirectory..

then again there is project.build.encoding that starts with project. but is actually just a property. that's probably why I kept the project. stuff around..

${basedir} is something we don't want o hyperlink for sure.
Comment 7 Matthew Piggott CLA 2011-03-07 10:00:55 EST 
Created attachment 190552 [details]
Disable hyperlink for unknown
Comment 8 Matthew Piggott CLA 2011-03-07 12:43:07 EST 
Created attachment 190579 [details]
Fixed disable hyperlink patch
Comment 9 Milos Kleint CLA 2011-03-08 02:26:38 EST 
applied matt's latest patch
http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=197e50636a742133fca9a146049d9e4512a301cf
Comment 10 Denis Roy CLA 2021-04-19 13:26:36 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/