Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338427 - JSDT now disallows most locations for setting breakpoints
Summary: JSDT now disallows most locations for setting breakpoints
Status: VERIFIED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Michael Rennie CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 10:36 EST by Grant Gayed CLA
Modified: 2011-02-28 13:59 EST (History)
1 user (show)

See Also:

Attachments
fix (3.02 KB, patch)
2011-02-28 13:16 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2011-02-28 10:36:08 EST 
I think this was introduced as a side effect of Friday's changes for bug 328531.  I've tried several pages with scripts that I've been using as test cases for a while, and it's now almost impossible to find a location that JSDT considers valid for setting a breakpoint.  This makes Crossfire development difficult since most of it is used after a breakpoint has been hit.
Comment 1 Michael Rennie CLA 2011-02-28 11:58:11 EST 
(In reply to comment #0)
> I think this was introduced as a side effect of Friday's changes for bug
> 328531.  I've tried several pages with scripts that I've been using as test
> cases for a while, and it's now almost impossible to find a location that JSDT
> considers valid for setting a breakpoint.  This makes Crossfire development
> difficult since most of it is used after a breakpoint has been hit.

Can you attach some example scripts?
Comment 2 Michael Rennie CLA 2011-02-28 13:16:09 EST 
Created attachment 189978 [details]
fix

For some reason I added in code that checked if the resulting JavaScriptUnit had errors, and if so, do not allow a breakpoint to be set. Obviously we want to allow breakpoints to be set regardless of compilation problems in the script.
Comment 3 Michael Rennie CLA 2011-02-28 13:17:04 EST 
applied to HEAD, Grant please verify.