Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338425 - Please add Win64 integration fragment to the builds
Summary: Please add Win64 integration fragment to the builds
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 226482
  Show dependency tree
 
Reported: 2011-02-28 10:27 EST by Oleg Besedin CLA
Modified: 2011-03-02 13:33 EST (History)
2 users (show)

See Also:

Attachments
patch to org.eclipse.equinox.core.sdk feature (1.96 KB, patch)
2011-02-28 11:03 EST, Thomas Watson CLA 		no flags Details | Diff
patch for platform feature (816 bytes, patch)
2011-02-28 11:16 EST, Kim Moir CLA 		no flags Details | Diff
patch to org.eclipse.equinox.core.sdk feature (1.96 KB, patch)
2011-02-28 11:27 EST, Thomas Watson CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2011-02-28 10:27:51 EST 
As a part of the bug 226482 the new fragment was created to support Windows 64-bit specific functinality:

org.eclipse.equinox/security/bundles/org.eclipse.equinox.security.win32.x86_64

This fragments needs to be added to the builds.
Comment 1 Thomas Watson CLA 2011-02-28 11:03:36 EST 
Created attachment 189955 [details]
patch to org.eclipse.equinox.core.sdk feature

This patch adds the new fragment to org.eclipse.equinox.core.sdk feature, but I am not sure what is required to get the new x86_64 win fragment added to the SDK for win x86_64.
Comment 2 Thomas Watson CLA 2011-02-28 11:04:40 EST 
I already added an entry to core.map for the org.eclipse.equinox.security.win32.x86_64.  But I do not plan to release any other changes until after the I-Build tomorrow.  Kim, let me know if/when you would like to do a test build.
Comment 3 Kim Moir CLA 2011-02-28 11:16:37 EST 
Created attachment 189959 [details]
patch for platform feature

Tom, do you want me to wait until after the I-build to make this change?
Comment 4 Thomas Watson CLA 2011-02-28 11:27:55 EST 
Created attachment 189965 [details]
patch to org.eclipse.equinox.core.sdk feature

Previous patch used x86 for the arch (should be x86_64)

I would prefer to not include this in the I-Build to avoid breaking the build.  We can do a test build tomorrow afternoon.
Comment 5 Kim Moir CLA 2011-02-28 11:32:44 EST 
Sure sounds good.  I can't run a test build right now anyways because of bug 336246
Comment 6 Kim Moir CLA 2011-03-02 13:33:33 EST 
Verified in test build, tagged for I-build.