Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338400 - Allow for binary cycles in target platform
Summary: Allow for binary cycles in target platform
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Libra (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Holger Staudacher CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 06:42 EST by Farooq Kamal CLA
Modified: 2022-02-24 11:24 EST (History)
4 users (show)

See Also:

Attachments
ExportWARProductWizard patch (220.99 KB, patch)
2011-04-15 16:09 EDT, Cole Markham CLA 		no flags Details | Diff
Replacement patch (1.46 KB, patch)
2011-04-15 16:13 EDT, Cole Markham CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Farooq Kamal CLA 2011-02-28 06:42:37 EST 
Build Identifier: 1.4 M5

Allow for binary cycles in target platform option required in war product export

Reproducible: Always
Comment 1 Cole Markham CLA 2011-04-15 16:09:33 EDT 
Created attachment 193405 [details]
ExportWARProductWizard patch

This is an intermediate patch to get binary cycle support. All I did is change ExportWARProductWizard to grab the values for populating the FeatureExportInfo from the ExportPage using existing methods. ExportPage.doBinaryCycles() was already set to return true, so I didn't have to change it there.

The next step will be to have the ExportPage actually include a checkbox like the PDE Product export wizard does.

This is my first attempt at creating a patch from git, so if it's not right let me know what I need to do. I just committed to my local git and then went to the History view for the file and selected "Create Patch".
Comment 2 Cole Markham CLA 2011-04-15 16:13:27 EDT 
Created attachment 193406 [details]
Replacement patch

Clearly something was wrong with the other patch.
Comment 3 Kaloyan Raev CLA 2011-08-18 14:23:10 EDT 
Holger, there is a patch attached to this ticket for several months. Could you review it and decide if it can be accepted?
Comment 4 Holger Staudacher CLA 2011-08-19 04:35:33 EDT 
Sorry, this was under my radar. Patch will be reviewed within the next week.
Comment 5 Rockhopper CLA 2013-03-19 03:34:04 EDT 
The provided patch works for me.

Ref:
 Replacement patch (1.46 KB, patch) 
 2011-04-15 16:13 EDT, Cole Markham
Comment 6 Nico Rutishauser CLA 2014-05-15 08:35:22 EDT 
Will this patch be reviewed and finally integrated?