Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338372 - compile warnings in official build
Summary: compile warnings in official build
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.6.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 03:55 EST by Dani Megert CLA
Modified: 2011-03-01 02:14 EST (History)
0 users

See Also:


Attachments
fix (60.77 KB, patch)
2011-02-28 12:29 EST, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-02-28 03:55:31 EST
N20110227-2000.

/src/org/eclipse/pde/api/tools/model/tests/TagScannerTests.java : 3 warnings :
1. WARNING in /src/org/eclipse/pde/api/tools/model/tests/TagScannerTests.java
 (at line 90)
fail(MessageFormat.format("Error scanning: {0}", new String[] {name}));
The argument of type String[] should explicitly be cast to Object[] for the invocation of the varargs method format(String, Object...) from type MessageFormat. It could alternatively be cast to Object for a varargs invocation

2. WARNING in /src/org/eclipse/pde/api/tools/model/tests/TagScannerTests.java
 (at line 104)
fail(MessageFormat.format("Error scanning: {0}", new String[] {name}));
The argument of type String[] should explicitly be cast to Object[] for the invocation of the varargs method format(String, Object...) from type MessageFormat. It could alternatively be cast to Object for a varargs invocation

3. WARNING in /src/org/eclipse/pde/api/tools/model/tests/TagScannerTests.java
 (at line 119)
fail(MessageFormat.format("Error scanning: {0}", new String[] {name}));
The argument of type String[] should explicitly be cast to Object[] for the invocation of the varargs method format(String, Object...) from type MessageFormat. It could alternatively be cast to Object for a varargs invocation


/src/org/eclipse/pde/api/tools/util/tests/ApiDescriptionProcessorTests.java : 1 warning :
1. WARNING in /src/org/eclipse/pde/api/tools/util/tests/ApiDescriptionProcessorTests.java
 (at line 241)
change = new TextFileChange(MessageFormat.format(WizardMessages.JavadocTagRefactoring_2, new String[] {file.getName()}), file);
The argument of type String[] should explicitly be cast to Object[] for the invocation of the varargs method format(String, Object...) from type MessageFormat. It could alternatively be cast to Object for a varargs invocation
Comment 1 Michael Rennie CLA 2011-02-28 12:29:13 EST
Created attachment 189971 [details]
fix

The patch fixes up the mentioned warnings and many more including:

1. deprecated use of new DefaultScope() and new InstanceScope()
2. access warnings to PDE core
3. access warnings to PDE UI
4. raw collection warnings
5. synthetic accessor use
Comment 2 Michael Rennie CLA 2011-02-28 12:30:41 EST
applied patch to HEAD
Comment 3 Dani Megert CLA 2011-03-01 02:14:56 EST
Verified in N20110228-2000.