Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338322 - for feature based diagnostic also consider index
Summary: for feature based diagnostic also consider index
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-27 02:53 EST by Henrik Rentz-Reichert CLA
Modified: 2017-09-19 17:17 EDT (History)
2 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
patch considering the index (17.99 KB, patch)
2011-02-27 02:58 EST, Henrik Rentz-Reichert CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Rentz-Reichert CLA 2011-02-27 02:53:21 EST 
From the call
org.eclipse.xtext.validation.AbstractDeclarativeValidator.error(String, EObject, EStructuralFeature, int)
a FeatureBasedDiagnostic is create but the index is never considered.

Therefore in a EReference 0..* always the first element is marked.
Comment 1 Henrik Rentz-Reichert CLA 2011-02-27 02:58:38 EST 
Created attachment 189888 [details]
patch considering the index

The patch fixes the problem and is validated in the eTrice project.
Comment 2 Sven Efftinge CLA 2011-03-26 14:52:25 EDT 
fixed and pushed to master
Comment 3 Sven Efftinge CLA 2011-05-20 03:28:08 EDT 
for the IP team: I didn't apply the attached patch, but just fixed the problem.
Comment 4 Karsten Thoms CLA 2017-09-19 17:06:02 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 17:17:53 EDT 
Closing all bugs that were set to RESOLVED before Neon.0