Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338291 - Toggle Comment not working in PHP Editor
Summary: Toggle Comment not working in PHP Editor
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal with 15 votes (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact: Ilina Stefanova CLA
URL:
Whiteboard:
Keywords:
: 339805 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-25 19:01 EST by Missing name CLA
Modified: 2020-05-14 11:53 EDT (History)
19 users (show)

See Also:


Attachments
Eclipse configuration (493.45 KB, text/plain)
2011-03-08 19:01 EST, Missing name CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name CLA 2011-02-25 19:01:38 EST
Build Identifier: M20110210-1200

I just reinstalled Eclipse so that I could get the newer version of PDT (2.2.1.v20101001-2300-53184QAN4JBQgLYPWMLcXn6Na9Od) that fixes the comparison view. Hurry, it works now!
However, when I went to comment out a line with the standard Ctrl+/ key combination, I found that I could not do it. I've confirmed that comments work in different editors (CSS Editor, HTML Editor, JS Editor), but the PHP Editor will not toggle comments (or add block comments), to any kind of code I've tried (HTML,PHP,JS).

I did notice that if I attempted to toggle comment on about 10 or more lines of HTML code (in the PHP Editor), a small dialog box pops up for a split second that says "Toggling Line Comments..."

Reproducible: Always

Steps to Reproduce:
1.Open php file in php editor
2.Try to comment out a line either by using Ctrl+/ or through the Source->Toggle Comment menu
3.Nothing happens
Comment 1 contact CLA 2011-03-01 03:52:23 EST
Same here on MacOSX.
Comment 2 Michael Pelz-Sherman CLA 2011-03-03 13:08:54 EST
+1 on Mac Snow Leopard. Please fix this!!!
Comment 3 avpoubs CLA 2011-03-07 05:52:07 EST
+1 on Windows XP SP 3 :

-> "Ctrl + Shift + /" to add block comment on one or multiple lines does not work
-> same for "Source + Add Block Comment"
-> same if I customize Key (e.g. "Ctrl + :")
-> same for "Remove block comment"
-> works for Javascript files
-> seems to doesn't work for HTML and CSS files

Some informations about my config :

Eclipse for PHP Developers
Version: Helios Service Release 2
Build id: 20110301-1815

Eclipse IDE for PHP Developers
epp.package.php (1.3.2.20110301-1807)

Eclipse Platform 
org.eclipse.platform.ide (3.6.2.M20110210-1200)
org.eclipse.platform.feature.group (3.6.2.r362_v20110210-9gF78Gs1FrIGnHDHWkEcopoN8AmxeZflGDGKQi)

Eclipse Web Developer Tools
org.eclipse.wst.web_ui.feature.feature.group
(3.2.3.v201102160541-7O7CFbWEMf84qYjGDyP3DNEwcgFU)
Comment 4 Stefan CLA 2011-03-08 03:41:35 EST
Same here:

I recently installed Eclipse IDE for PHP Developers 1.3.2. (which includes PDT 2.2.1) and I can't toggle comments anymore.
I also installed some of the PHP Tools Integration (PTI) tools (http://phpsrc.org/):

PHP Copy/Paste Detection 0.2.2.R20100414000000
PHP Tool CodeSniffer 1.2.6.R20100912000000
PHP Tool PHPUnit 0.7.0.R201012220000000

A coworker has the same problem, but has installed PDT 2.2.0 in an Eclipse Helios SR 0 environment.
He also has the same PTI tools installed.

However, before the installation of the PTI tools, he didn't have this problem.
Comment 5 Missing name CLA 2011-03-08 19:01:21 EST
Created attachment 190715 [details]
Eclipse configuration

Here's my configuration log, if that helps anyone.
Comment 6 janga41 CLA 2011-03-12 16:15:06 EST
*** Bug 339805 has been marked as a duplicate of this bug. ***
Comment 7 janga41 CLA 2011-03-12 16:16:54 EST
+1 Just had the same problem after running update from the help menu on windows 7.... no method to toggle comments that i have tried has worked yet.
Comment 8 cmacrander CLA 2011-03-18 10:40:41 EDT
Yet another PDT user who would like commenting to work again.
Comment 9 Nitin Dahyabhai CLA 2011-03-18 11:30:46 EDT
(In reply to comment #8)
> Yet another PDT user who would like commenting to work again.

This could be the result of fixing bug 86520, and the near omission for XML mentioned in bug 86520 comment 41 (which uses the org.eclipse.wst.sse.ui.commentingStrategy extension point).  It wouldn't explain bug 199730 comment 7, though.
Comment 10 bjørn wikkeling CLA 2011-03-20 12:39:27 EDT
+1
reinstall didn't fix the problem :(
Comment 11 Romain Dequidt CLA 2011-04-01 08:11:39 EDT
So, what's the solution/bypass?

Is it going to be corrected within the next release?
Comment 12 Zhongwei Zhao CLA 2011-04-01 08:17:03 EDT
hi all,

This has been fixed in head,it will work in next release!
Comment 13 Missing name CLA 2011-04-01 17:42:48 EDT
(In reply to comment #12)
> hi all,
> 
> This has been fixed in head,it will work in next release!

Great! Any idea when the next release is? Is there a milestone update URL we can use in the meantime?

For anyone who's interested in skipping the updater, there is a fix here: http://sourceforge.jp/projects/pdt-tools/releases/51060
Comment 14 Jérémy T. CLA 2011-04-06 02:09:28 EDT
> For anyone who's interested in skipping the updater, there is a fix here:
> http://sourceforge.jp/projects/pdt-tools/releases/51060

I tried replacing all three files in Eclipse' plugins directory and restarted Eclipse but still nothing (Source > Add Block Comment doesn't even work via the menu).

Did I do that wrong?
Comment 15 bjørn wikkeling CLA 2011-04-06 04:04:48 EDT
Thank you so much for fixing this! it works like a charm again :-)

@sielver you should start Eclipse with the -clean swith, then it works
Comment 16 Missing name Mising name CLA 2011-04-06 11:04:29 EDT
Is it an aprils fools joke that this is fixed? I'm a bit puzzeled because I have not found any URL where I can download something that will fix this.

Please share the fix.
Comment 17 bjørn wikkeling CLA 2011-04-06 11:11:11 EDT
see @sielver's post:
http://sourceforge.jp/projects/pdt-tools/releases/51060
[don't forget to start Eclipse with the -clean switch once you've copied the files]

(In reply to comment #16)
> Is it an aprils fools joke that this is fixed? I'm a bit puzzeled because I
> have not found any URL where I can download something that will fix this.
> 
> Please share the fix.
Comment 18 Missing name Mising name CLA 2011-04-06 11:24:18 EDT
Okay I was looking for an update URL that I can make use of from the eclipse GUI.

I could however replace the files with the same names with the files to download from http://sourceforge.jp/projects/pdt-tools/releases/51060.

Then I restarted eclipse with -clean (eclipse -clean).

This did fix the issue.

Thanks for the feedback.

(In reply to comment #17)
> see @sielver's post:
> http://sourceforge.jp/projects/pdt-tools/releases/51060
> [don't forget to start Eclipse with the -clean switch once you've copied the
> files]
> 
> (In reply to comment #16)
> > Is it an aprils fools joke that this is fixed? I'm a bit puzzeled because I
> > have not found any URL where I can download something that will fix this.
> > 
> > Please share the fix.
Comment 19 Zhongwei Zhao CLA 2011-04-13 02:07:14 EDT
fixed
Comment 20 Ilina Stefanova CLA 2011-08-03 09:11:50 EDT
Verified.
Comment 21 Nitin Dahyabhai CLA 2011-08-04 18:53:26 EDT
(In reply to comment #20)
> Verified.

What version/build ID should users be looking for to be sure they have the fix installed?
Comment 22 a6299141 CLA 2011-09-24 00:10:53 EDT
How to  <a href="http://www.hairextensionsusa.com/feather-hair-extensions/">hair feathers extensions</a>. Feathering is a hair-cutting technique that results in wispy, light <a href="http://www.hairextensionsusa.com/clip-in-hair-extensions/">human hair clip in extensions</a> ends--it's also popular to create layers and remove bulk.a Victorian Feather Hairpiecethumbnail Make a <a href="http://www.hairextensionsusa.com/feather-hair-extensions/">feather locks hair extensions</a> inspired by <a href="http://www.hairextensionsusa.com/clip-in-hair-extensions/">human hair clip in extensions</a>.
Comment 23 m f CLA 2013-03-27 09:58:17 EDT
I have this issue with 
Version: 3.7.2
Build id: I20110613-1736

Its the version bundled with Ubuntu 12.04 .