Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338286 - Right clicking on the activate button in the task list should not activate the task
Summary: Right clicking on the activate button in the task list should not activate th...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 3.5   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-25 17:04 EST by Sam Davis CLA
Modified: 2011-03-01 00:44 EST (History)
1 user (show)

See Also:


Attachments
patch V1 (1010 bytes, patch)
2011-02-28 15:24 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (7.77 KB, application/octet-stream)
2011-02-28 15:24 EST, Frank Becker CLA
no flags Details
mylyn/context/zip (14.11 KB, application/octet-stream)
2011-03-01 00:44 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2011-02-25 17:04:36 EST
Right clicking on the activate button in the task list both activates the task and brings up a context menu. When I right click a task, I want the menu, I don't want it activated. Middle click on this button should probably also be ignored.
Comment 1 Steffen Pingel CLA 2011-02-25 17:59:15 EST
I'll take a look. I would like to middle click to activate and open the editor.
Comment 2 Sam Davis CLA 2011-02-25 18:21:45 EST
(In reply to comment #1)
> I would like to middle click to activate and open the editor.

That would be great. Maybe Ctrl+click should do that too. I thought there was a shortcut for this already but I can't find it.
Comment 3 Steffen Pingel CLA 2011-02-25 20:22:26 EST
Shift clicking in the activation history works. We should probably make this consistent when activating from the task list.
Comment 4 Steffen Pingel CLA 2011-02-27 15:21:58 EST
To summarize, here is what I suggest: Shift+Left-click and Middle-click activate the task and bring the task editor to the front. Right-click show the context menu and does not activate the task.
Comment 5 Sam Davis CLA 2011-02-28 12:03:10 EST
Makes sense to me.
Comment 6 Frank Becker CLA 2011-02-28 15:24:14 EST
Created attachment 189990 [details]
patch V1

Steffen,

here is a fix for the context menu.

Because I have only a trackpad I can not test if this work with a three button mouse.

Can you please test that now only the context menu is opened  when you right click over the activate icon.
Comment 7 Frank Becker CLA 2011-02-28 15:24:19 EST
Created attachment 189991 [details]
mylyn/context/zip
Comment 8 Steffen Pingel CLA 2011-03-01 00:44:37 EST
Thanks. I have added support for middle clicking and shift clicking as well.
Comment 9 Steffen Pingel CLA 2011-03-01 00:44:40 EST
Created attachment 190015 [details]
mylyn/context/zip