Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338284 - wikitext fails to draw strikethrough if hyphen between words is present
Summary: wikitext fails to draw strikethrough if hyphen between words is present
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 1.4.0   Edit
Assignee: David Green CLA
QA Contact: David Green CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-25 17:01 EST by Mik Kersten CLA
Modified: 2011-03-02 14:28 EST (History)
0 users

See Also:

Attachments
mylyn/context/zip (57.89 KB, application/octet-stream)
2011-03-01 16:41 EST, David Green CLA 		no flags Details
mylyn/context/zip (64.12 KB, application/octet-stream)
2011-03-02 14:28 EST, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mik Kersten CLA 2011-02-25 17:01:02 EST 
Works: -strike out-
Fails: -strike-out-
Comment 1 Mik Kersten CLA 2011-02-25 17:01:35 EST 
David: Let's try to do this for Mylyn 3.6.
Comment 2 David Green CLA 2011-03-01 16:41:32 EST 
fixed for 1.4 (for Mylyn 3.6)

Note that this change makes phrase modifiers more greedy, and will affect the following markup constructs:
* bold text, using **
* citation, using ??
* italic, using __
* emphasis, using _
* strong, using *
* inserted, using +
* subscript, using ~
* superscript, using ^
* code, using @
* span, using %
* deleted, using -

If you notice anything strange please let me know.
Comment 3 David Green CLA 2011-03-01 16:41:35 EST 
Created attachment 190095 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2011-03-01 19:15:00 EST 
(In reply to comment #2)
> fixed for 1.4 (for Mylyn 3.6)

1.4 will be part of Mylyn 3.5 :).
Comment 5 Steffen Pingel CLA 2011-03-02 02:00:23 EST 
https://hudson.eclipse.org/hudson/user/spingel/my-views/view/Mylyn/job/mylyn-heartbeat/163/testReport/org.eclipse.mylyn.wikitext.textile.core/TextileLanguageTasksTest/testSubversiveBugReport/

Test Results for Build 163
org.eclipse.mylyn.tests.AllHeartbeatTests
org.eclipse.mylyn.wikitext.textile.core.TextileLanguageTasksTest
testSubversiveBugReport(org.eclipse.mylyn.wikitext.textile.core.TextileLanguageTasksTest)
java.lang.StackOverflowError
	at java.util.regex.Pattern$Loop.match(Pattern.java:4275)
	at java.util.regex.Pattern$GroupTail.match(Pattern.java:4227)
	at java.util.regex.Pattern$BranchConn.match(Pattern.java:4078)
	at java.util.regex.Pattern$CharProperty.match(Pattern.java:3345)
	at java.util.regex.Pattern$Branch.match(Pattern.java:4114)
	at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168)
Comment 6 David Green CLA 2011-03-02 14:28:36 EST 
Ack - sorry, I only ran part of the test suite before pushing.  

Fixed this problem, cleaned up the regex and added more tests.
All tests are now passing.
Comment 7 David Green CLA 2011-03-02 14:28:42 EST 
Created attachment 190191 [details]
mylyn/context/zip