Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338282 - Test failures in BundleImporterTests
Summary: Test failures in BundleImporterTests
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 338287
Blocks:
  Show dependency tree
 
Reported: 2011-02-25 16:48 EST by Curtis Windatt CLA
Modified: 2011-03-02 14:26 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-02-25 16:48:56 EST 
junit.framework.AssertionFailedError: null
at org.eclipse.pde.ui.tests.project.BundleImporterTests.testGetImportDescriptions(BundleImporterTests.java:48)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:416)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:249)
at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3524)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3173)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)

AND

expected:<[CVS Bundle ]Importer> but was:<[%cvsBundle]Importer>

junit.framework.ComparisonFailure: null expected:<[CVS Bundle ]Importer> but was:<[%cvsBundle]Importer>
at org.eclipse.pde.ui.tests.project.BundleImporterTests.testBundleImporters(BundleImporterTests.java:59)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:416)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:249)
at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
Comment 1 Curtis Windatt CLA 2011-02-25 17:15:35 EST 
I moved these tests inside the import suite.  I missed running them when fixing the previous DNF tests as I assumed that all import tests would be part of the import suite.

I'm not sure what is causing the first test failure.  I changed the plug-in being imported to JDT to make it easier for PDE devs to work debug (because of target weaving).

Second bug is actually because Team hasn't NLS'd the extension correctly.  I will file a bug against them.
Comment 2 Curtis Windatt CLA 2011-02-28 10:38:32 EST 
Tomasz, our testGetImportDescriptions test is failing in HEAD, but passes locally.  The url returned from the import description doesn't match our expected value.  If you have any idea what the cause could be, please let me know.

I have updated the test to print out the url the description returns.

I plan to disable this test for the I build.
Comment 3 Curtis Windatt CLA 2011-03-02 14:26:39 EST 
Tests were re-enabled.  Had one additional failure as the expected URL had an extra colon at the end.  Fixed in HEAD.  Marking as FIXED.