Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338273 - commit messages should be 72 characters instead of 70
Summary: commit messages should be 72 characters instead of 70
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-25 15:19 EST by Brad Cupit CLA
Modified: 2011-05-10 07:44 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Cupit CLA 2011-02-25 15:19:42 EST
Build Identifier: 

Hard-wrapping commits is an awesome feature (and the gray vertical bar is nice too), but for some reason it happens at 70 characters instead of the generally accepted 72.

The quintessential source for git commit comment etiquette is:
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

Reproducible: Always

Steps to Reproduce:
1. write a commit comment
2. notice the vertical gray bar at column 70 instead of 72
Comment 1 Matthias Sohn CLA 2011-05-10 05:31:29 EDT
pushed patch for review: 
http://egit.eclipse.org/r/#change,3372
Comment 2 Matthias Sohn CLA 2011-05-10 07:44:25 EDT
merged as c70053785dff09aa888d87174bccffa63ff5d206