Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338220 - [generator] EcoreGeneratorFragment.referencedGenModels should be a list
Summary: [generator] EcoreGeneratorFragment.referencedGenModels should be a list
Status: CLOSED WONTFIX
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-25 09:13 EST by Jan Koehnlein CLA
Modified: 2017-09-19 17:09 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Koehnlein CLA 2011-02-25 09:13:04 EST 
Currently, the property is a String that takes a comma separated list. This is not very suggestive. We should rather have an multi-valued string feature. this would also allow for easier static analysis.
Comment 1 Knut Wannheden CLA 2011-02-25 10:19:00 EST 
I suppose a downside to this would be that it wouldn't be as easy to use MWE2 variables anymore to specify the list of GenModels.

We currently have a workflow Common.mwe2 with:

var referencedGenModels = ""

and then later:

fragment = EcoreGeneratorFragment auto-inject {}

We then call this workflow from multiple Xtext projects, so we can keep duplication at a minimum.

Or does MWE2 support some kind of String -> List conversion that I don't know of?
Comment 2 Sebastian Zarnekow CLA 2011-02-25 10:21:55 EST 
We could still use the splitting algorithm that we used in the past but simply switch from setReferenced... to addReferenced. It would be backwards compatible and more intuitive for new users.
Comment 3 Knut Wannheden CLA 2011-02-25 10:24:41 EST 
I wasn't aware of this splitting algorithm. But that sounds good.
Comment 4 Jan Koehnlein CLA 2011-06-29 08:58:31 EDT 
EcoreGeneratorFragment.referencedGenModels has been deprecated. Use StandaloneSetup.registerGenModelFile instead, which is a list.

Closing this issue as won't fix.
Comment 5 Karsten Thoms CLA 2017-09-19 16:58:28 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 6 Karsten Thoms CLA 2017-09-19 17:09:41 EDT 
Closing all bugs that were set to RESOLVED before Neon.0