Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338216 - Add checkbox in pref/prop page for One-to-Many old style relation in JPA 2.0 projects
Summary: Add checkbox in pref/prop page for One-to-Many old style relation in JPA 2.0 ...
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Stefan Dimov CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 338395
  Show dependency tree
 
Reported: 2011-02-25 08:13 EST by Stefan Dimov CLA
Modified: 2011-04-26 14:36 EDT (History)
2 users (show)

See Also:

Attachments
patch (22.39 KB, patch)
2011-02-28 04:40 EST, Stefan Dimov CLA 		no flags Details | Diff
patch v2 (24.67 KB, patch)
2011-02-28 04:48 EST, Stefan Dimov CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Dimov CLA 2011-02-25 08:13:31 EST 
In JPA 2.0 One-to-Many unidir relationships are supposed to have additional annotation @JoinColumn(s) of the relationship mapping attribute. (This way the DB tables will be generated without additional join table.) The old style rels are still supported for backward compatibility. 

The natural behavior of the editor (in JPA 2.0 projects) is to create One-to-Many unidir rel with @JoinColumn(s). Nevertheless we'd like to leave the user with an option here: 

There should be a checkbox in the editor pref/prop page which allows the user (if she checks is) to create an old style (JPA 1.0) One-to-Many unidir rels (in JPA 2.0 projects), i.e. - if this checkbox is checked the new 1-N unidir rels will be created without @JoinColumn(s)
Comment 1 Stefan Dimov CLA 2011-02-28 04:40:15 EST 
Created attachment 189920 [details]
patch
Comment 2 Stefan Dimov CLA 2011-02-28 04:48:06 EST 
Created attachment 189924 [details]
patch v2

Fixes 'non-externalized string' warnings
Comment 3 Stefan Dimov CLA 2011-02-28 06:14:22 EST 
Patch committed ...
Comment 4 Jolene Moffitt CLA 2011-04-26 14:36:48 EDT 
Verified in Build I-3.3.0-20110414085808

Verified checkbox appears in the properties. See the link to view test steps for verification. http://wiki.eclipse.org/Dali_3.0_M6